forked from opensearch-project/sql
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix truncate() function #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2ee64f3
Fix truncate() function
margarit-h ca87242
Address PR review feedback
margarit-h 10ae053
Edit a javadoc
margarit-h a9e18e5
Add/fix tests
margarit-h ba76b90
Address PR review feedback
margarit-h d91ec92
Added more tests
margarit-h 21619b4
Addressed more PR review feedback
margarit-h 8599dbd
minor fix
margarit-h 5622094
Clean up, apdate a unit test
margarit-h 3cde7ce
minor fix
margarit-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { "index" : { "_id" : "1" } } | ||
| {"key": "null", "val": null} | ||
| { "index" : { "_id" : "2" } } | ||
| {"key": "001: min long", "val": -9.223372036854776e+18} | ||
| { "index" : { "_id" : "3" } } | ||
| {"key": "002: min int minus one", "val": -2147483649.0} | ||
| { "index" : { "_id" : "4" } } | ||
| {"key": "003: min int", "val": -2147483648.0} | ||
| { "index" : { "_id" : "5" } } | ||
| {"key": "004: min short minus one", "val": -32769.0} | ||
| { "index" : { "_id" : "6" } } | ||
| {"key": "005: min short", "val": -32768.0} | ||
| { "index" : { "_id" : "7" } } | ||
| {"key": "006: pgtest float8 value 2", "val": -34.84} | ||
| { "index" : { "_id" : "8" } } | ||
| {"key": "007: -two", "val": -2.0} | ||
| { "index" : { "_id" : "9" } } | ||
| {"key": "008: -1.2", "val": -1.2} | ||
| { "index" : { "_id" : "10" } } | ||
| {"key": "009: -one", "val": -1.0} | ||
| { "index" : { "_id" : "11" } } | ||
| {"key": "010: zero", "val": 0.0} | ||
| { "index" : { "_id" : "12" } } | ||
| {"key": "011: one", "val": 1.0} | ||
| { "index" : { "_id" : "13" } } | ||
| {"key": "012: 1.3", "val": 1.3} | ||
| { "index" : { "_id" : "14" } } | ||
| {"key": "013: two", "val": 2.0} | ||
| { "index" : { "_id" : "15" } } | ||
| {"key": "014: pgtest float8 value 1", "val": 1004.3} | ||
| { "index" : { "_id" : "16" } } | ||
| {"key": "015: max short", "val": 32767.0} | ||
| { "index" : { "_id" : "17" } } | ||
| {"key": "016: max short plus one", "val": 32768.0} | ||
| { "index" : { "_id" : "18" } } | ||
| {"key": "017: max int", "val": 2147483647.0} | ||
| { "index" : { "_id" : "19" } } | ||
| {"key": "018: max int plus one", "val": 2147483648.0} | ||
| { "index" : { "_id" : "20" } } | ||
| {"key": "019: max long", "val": 9.223372036854776e+18} |
12 changes: 12 additions & 0 deletions
12
integ-test/src/test/resources/indexDefinitions/double_index_mapping.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "mappings" : { | ||
| "properties" : { | ||
| "key" : { | ||
| "type" : "keyword" | ||
| }, | ||
| "val" : { | ||
| "type" : "double" | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.