Add Month_Of_Year Function To OpenSearch #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## integ-add-month_of_year-function #174 +/- ##
======================================================================
- Coverage 98.28% 95.75% -2.53%
- Complexity 3450 3451 +1
======================================================================
Files 345 355 +10
Lines 8580 9241 +661
Branches 547 666 +119
======================================================================
+ Hits 8433 8849 +416
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: GabeFernandez310 <[email protected]>
GabeFernandez310
changed the title
|
If it makes sense, could there be IT tests for datetime values and null values? Could also make a query on calcs with columns that have null values. |
forestmvey
reviewed
Nov 23, 2022
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Outdated
Show resolved
Hide resolved
forestmvey
reviewed
Nov 23, 2022
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Show resolved
Hide resolved
MitchellGale
requested changes
Nov 23, 2022
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Show resolved
Hide resolved
acarbonetto
reviewed
Nov 24, 2022
Yury-Fridlyand
suggested changes
Nov 25, 2022
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Show resolved
Hide resolved
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Yury-Fridlyand
approved these changes
Nov 29, 2022
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Author
Fixed in b71c37e |
Yury-Fridlyand
approved these changes
Nov 29, 2022
Yury-Fridlyand
requested review from
GumpacG,
MaxKsyunz,
forestmvey and
margarit-h
margarit-h
approved these changes
Nov 29, 2022
MitchellGale
approved these changes
Nov 29, 2022
GumpacG
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
month_of_yearfunction to the SQL plugin. It behaves like themonthfunction which already exists in the new engine, and both are aligned with MySQLIssues Resolved
opensearch-project#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.