Skip to content

Update TIMESTAMP function #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yury-Fridlyand merged 14 commits into from
Dec 20, 2022
Merged

Update TIMESTAMP function #139

Yury-Fridlyand merged 14 commits into from
Dec 20, 2022

Conversation

@Yury-Fridlyand
Copy link

@Yury-Fridlyand Yury-Fridlyand commented Oct 20, 2022 •
edited
Loading

Description

Depends on #132/opensearch-project#1194

I referred to MySQL docs and tried to reproduce MySQL v.8.0.30 behavior as a reference.

Updated function: TIMESTAMP

Signatures

(STRING/DATE/TIME/DATETIME/TIMESTAMP) -> TIMESTAMP
(STRING/DATE/TIME/DATETIME/TIMESTAMP, STRING/DATE/TIME/DATETIME/TIMESTAMP) -> TIMESTAMP

Notes:

Unlike MySQL, TIMESTAMP function returns a TIMESTAMP object (Instant), not a DATETIME.

Test queries:

SELECT TIMESTAMP('2020-08-26 13:49:00'), TIMESTAMP('2020-08-26 13:49:00', TIME('12:15:42'));

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov

This comment was marked as spam.

Sign in to view
@acarbonetto acarbonetto changed the title Update TIMESTAMP function [BLOCKED] Update TIMESTAMP function Oct 25, 2022
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 28, 2022
Closed
Yury-Fridlyand and others added 12 commits December 12, 2022 18:40
@Yury-Fridlyand
Add functions ADDTIME and SUBTIME.
939539f 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Update docs - rework on examples.
3b01e6b 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Update ExprTimeValue by datetimeValue and other interfaces. Add c…
fbabe78 
…orresponding tests.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Update TIMESTAMP function implementation and signatures.
533281c 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Modify function to accept strings.
80affb7 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Return NULL on invalid string input.
e7db970 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Add unit tests.
df0b27c 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Update docs.
5e6423b 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Minor checkstyle fixes.
e257d5c 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Make function to throw an exception on incorrect input.
5e86202 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Fix rebasing errors.
86524aa 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Rework to use FunctionProperties.
84a1d4d 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Typo fix.
95ee90d 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand changed the title [BLOCKED] Update TIMESTAMP function Update TIMESTAMP function Dec 13, 2022
@acarbonetto
Copy link

acarbonetto commented Dec 15, 2022 •
edited
Loading

  1. Please add the description from your reference of what one vs two arguments is intended to do:
With a single argument, this function returns the date or datetime expression; with two arguments, the sum of the arguments
  1. For section Test queries: please include the results

@acarbonetto
Copy link

acarbonetto commented Dec 15, 2022

You can also reference opensearch-project#722 as part of this PR in that this PR does partially fix opensearch-project#722

acarbonetto
acarbonetto approved these changes Dec 15, 2022
View reviewed changes
Copy link

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question about getting timestampValue

core/src/main/java/org/opensearch/sql/utils/DateTimeUtils.java
FunctionProperties functionProperties) {
return value instanceof ExprTimeValue
? ((ExprTimeValue) value).timestampValue(functionProperties)
: value.timestampValue();
Copy link

@acarbonetto acarbonetto Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh. I do not like this logic is required here.
It would be better if the logic was in Expr*Value classes.

Copy link
Author

@Yury-Fridlyand Yury-Fridlyand Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example, please?

@Yury-Fridlyand @acarbonetto
Apply suggestions from code review
f938ea8 
Signed-off-by: Yury-Fridlyand <[email protected]>

Co-authored-by: Andrew Carbonetto <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit 3fcb2b3 into integ-update-timestamp Dec 20, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-update-timestamp branch December 20, 2022 02:32
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@MitchellGale MitchellGale MitchellGale approved these changes

@GumpacG GumpacG Awaiting requested review from GumpacG

@forestmvey forestmvey Awaiting requested review from forestmvey

@GabeFernandez310 GabeFernandez310 Awaiting requested review from GabeFernandez310

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

+1 more reviewer

@margarit-h margarit-h margarit-h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yury-Fridlyand @acarbonetto @MitchellGale @margarit-h @MaxKsyunz