Skip to content

Conversation

@GabeFernandez310
Copy link

@GabeFernandez310 GabeFernandez310 commented Sep 19, 2022

Description

Fix warning messages in GitHub actions associated with EqualsAndHashCode annotations.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GabeFernandez310 GabeFernandez310 requested a review from a team September 19, 2022 18:24
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #120 (09df0d0) into integ-fix-gha-warnings (929ebfe) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             integ-fix-gha-warnings     #120   +/-   ##
=========================================================
  Coverage                     94.83%   94.83%           
  Complexity                     2916     2916           
=========================================================
  Files                           291      291           
  Lines                          7795     7795           
  Branches                        567      567           
=========================================================
  Hits                           7392     7392           
  Misses                          349      349           
  Partials                         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/sql/planner/physical/AggregationOperator.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/DedupeOperator.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/FilterOperator.java 100.00% <ø> (ø)
...opensearch/sql/planner/physical/LimitOperator.java 100.00% <ø> (ø)
...ensearch/sql/planner/physical/ProjectOperator.java 100.00% <ø> (ø)
...nsearch/sql/planner/physical/RareTopNOperator.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/RemoveOperator.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/RenameOperator.java 100.00% <ø> (ø)
.../opensearch/sql/planner/physical/SortOperator.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@MitchellGale MitchellGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabeFernandez310 could you setup your git.username and git.email as well as GitHub profile to a globally addressable email address instead of *.local?

Here's GitHub help on the matter.

If you'd like to use a private email, GitHub generates one for you as well.

@GabeFernandez310 GabeFernandez310 merged commit ad35233 into integ-fix-gha-warnings Sep 19, 2022
@GabeFernandez310 GabeFernandez310 deleted the dev-fix-gha-warnings branch September 19, 2022 22:50
@MitchellGale
Copy link

Hey @GabeFernandez310,
core/src/main/java/org/opensearch/sql/ast/tree/Limit.java:20: warning: Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '@EqualsAndHashCode(callSuper=false)' to your type. @EqualsAndHashCode

/core/src/main/java/org/opensearch/sql/expression/ParseExpression.java:25: warning: Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '@EqualsAndHashCode(callSuper=false)' to your type. @EqualsAndHashCode

Looks like there are two more calls to EqualsAndHashCode that didn't get updated. Could you please see about updating them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants