Enable mock test #42
Merged
Enable mock test #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
force-pushed
the
enable-mock-test
branch
3 times, most recently
from
b375245 to
b58ed06
Compare
alinaliBQ
force-pushed
the
enable-mock-test
branch
from
b58ed06 to
063ea7b
Compare
So the tests can be skipped when `TEST_CONNECT_STR` is not set.
alinaliBQ
force-pushed
the
enable-mock-test
branch
from
bfd235d to
757c956
Compare
Wrap usage of TEST_CONNECT_STR where possible
alinaliBQ
force-pushed
the
enable-mock-test
branch
from
757c956 to
7b6f874
Compare
alinaliBQ
commented
Jun 9, 2025
Comment on lines
964
to
-981
|
|
||
| EXPECT_GT(message_length, 200); |
Author
There was a problem hiding this comment.
The error message from mock server is only 129 characters, so I adjusted this check
alinaliBQ
force-pushed
the
enable-mock-test
branch
from
c66594d to
3c1c14d
Compare
alinaliBQ
commented
Jun 10, 2025
Author
There was a problem hiding this comment.
We want to enable builds on clang64 and MinGW too. The driver should work on any Win32 platform
Comment on lines
+203
to
+204
Author
There was a problem hiding this comment.
We need to use this to indicate where we're getting the function when using TYPED_TEST
Comment on lines
78
to
85
Author
There was a problem hiding this comment.
This is based on code at cpp/src/arrow/flight/test_auth_handlers.h
There was a problem hiding this comment.
The ServerAuthHandler is sort of deprecated. This was for an older implementation of stateful authentication in Flight.
We should instead use a Server middleware to authenticate the token. That would intercept the headers and let you view the token header. This should run with every request (as it is stateless authentication). There might be one already written for this.
Author
There was a problem hiding this comment.
I didn't find an existing server that takes in a token as authentication but I did find middleware that does a username/password authentication check first, and then does a header token check (cpp/src/arrow/flight/flight_test.cc#L931-L932). Based on this, I wrote the mock server middleware to do just 1 layer of token check
Comment on lines
151
to
164
Author
There was a problem hiding this comment.
Mock server setup and teardown is based on cpp/src/arrow/flight/sql/server_test.cc
alinaliBQ
force-pushed
the
enable-mock-test
branch
2 times, most recently
from
493b2c3 to
2620adf
Compare
alinaliBQ
force-pushed
the
enable-mock-test
branch
from
2620adf to
c990015
Compare
jduo
reviewed
Jun 10, 2025
Use constant string for token
rscales
approved these changes
Jun 11, 2025
alinaliBQ
added a commit
that referenced
this pull request
Jun 17, 2025
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
alinaliBQ
added a commit
that referenced
this pull request
Jul 31, 2025
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
alinaliBQ
added a commit
that referenced
this pull request
Aug 20, 2025
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
alinaliBQ
added a commit
that referenced
this pull request
Aug 26, 2025
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
alinaliBQ
added a commit
that referenced
this pull request
Sep 9, 2025
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
alinaliBQ
added a commit
that referenced
this pull request
Sep 25, 2025
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable mock test.
Goal:
Inside the mock tests (that use
FlightSQLODBCMockTestBase), a mock in-memory SQLite server atlocalhost:<port>is set up before every test case and teardown afterwards.<port>is any available port. Theportvalue is saved to get the connection string for the mock server.graph TD; A[FlightSQLODBCTestBase]-->B[FlightSQLODBCMockTestBase]; A-->C[FlightSQLODBCRemoteTestBase];If we want a test to be run with remote server, use
TEST_F(FlightSQLODBCRemoteTestBase, <TestName>). In general, tests that run with mock server should also be runnable with remote server.If environment variable
ARROW_FLIGHT_SQL_ODBC_CONNis not set, the remote server tests are automatically skipped. This makes running tests with only mock server easier.