Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAC-50] [flightsql-odbc] Fail the workflow if build fails #14

Open
wants to merge 1 commit into
base: alinaliBQ/GAC-39/update-arrow-ver-flightsql-odbc
Choose a base branch
from

Conversation

affonsov
Copy link

@affonsov affonsov commented Jan 4, 2024

Rationale for this change

CMAKE build results were being swallowed after the cd ..
Now the result is captured and returned later

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

alinaliBQ
alinaliBQ previously approved these changes Jan 4, 2024
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Please do not merge the PR, we can just leave it open)

Copy link

github-actions bot commented Jan 4, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@affonsov affonsov force-pushed the affonsov/fix-github-action-not-failing-on-build branch from 9494c65 to 2fd7a18 Compare January 5, 2024 18:54
@affonsov affonsov changed the base branch from GAC-odbc-driver to alinaliBQ/GAC-39/update-arrow-ver-flightsql-odbc January 5, 2024 19:11
@affonsov affonsov force-pushed the affonsov/fix-github-action-not-failing-on-build branch 2 times, most recently from f491591 to 927f222 Compare January 5, 2024 21:24
@alinaliBQ alinaliBQ force-pushed the alinaliBQ/GAC-39/update-arrow-ver-flightsql-odbc branch from 5c03e97 to e6ba2c8 Compare January 5, 2024 22:32
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR. I see that the workflow fails properly when the build fails. I just have 2 minor comments. Will take another look when the test code in main.cc is removed.

cpp/src/flightsql_odbc/flightsql-odbc/build_win32.bat Outdated Show resolved Hide resolved
cpp/src/flightsql_odbc/flightsql-odbc/build_win64.bat Outdated Show resolved Hide resolved
@affonsov affonsov force-pushed the affonsov/fix-github-action-not-failing-on-build branch from 927f222 to 06ce06b Compare January 5, 2024 23:24
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants