Skip to content

Address general test code review comments #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

Address general test code review comments #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8921453
[in-progress] Address GH-46096 code review comments
alinaliBQ Oct 15, 2025
485f34e
Address GH-47708 code review comments
alinaliBQ Oct 16, 2025
fd43bd6
remove comment
alinaliBQ Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/binary_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/accessors/binary_array_accessor.h"
#include "arrow/testing/builder.h"
#include "arrow/testing/gtest_util.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/boolean_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@

#include "arrow/flight/sql/odbc/odbc_impl/accessors/boolean_array_accessor.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/date_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/accessors/boolean_array_accessor.h"
#include "arrow/flight/sql/odbc/odbc_impl/calendar_utils.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/decimal_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
#include "arrow/builder.h"
#include "arrow/testing/builder.h"
#include "arrow/util/decimal.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {
namespace {
Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/primitive_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@

#include "arrow/flight/sql/odbc/odbc_impl/diagnostics.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/string_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@

#include "arrow/flight/sql/odbc/odbc_impl/encoding.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/time_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/calendar_utils.h"
#include "arrow/flight/sql/odbc/odbc_impl/util.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/timestamp_array_accessor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/calendar_utils.h"
#include "arrow/flight/sql/odbc/odbc_impl/util.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_connection_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@

#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
#include "arrow/flight/types.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

#include <optional>

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_stream_chunk_buffer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/json_converter.h"
#include "arrow/flight/test_flight_server.h"
#include "arrow/flight/test_util.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/json_converter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
#include "arrow/scalar.h"
#include "arrow/testing/builder.h"
#include "arrow/type.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/parse_table_types_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/flight_sql_statement_get_tables.h"

#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/record_batch_transformer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
#include "arrow/record_batch.h"
#include "arrow/testing/builder.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {
namespace {
Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/util_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
#include "arrow/testing/builder.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/testing/util.h"
#include "gtest/gtest.h"

#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
6 changes: 2 additions & 4 deletions cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,13 @@
// under the License.
#include "arrow/flight/sql/odbc/tests/odbc_test_suite.h"

#ifdef _WIN32
# include <windows.h>
#endif
#include "arrow/flight/sql/odbc/odbc_impl/platform.h"

#include <sql.h>
#include <sqltypes.h>
#include <sqlucode.h>

#include "gtest/gtest.h"
#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {
// Helper functions
Expand Down
6 changes: 2 additions & 4 deletions cpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,13 @@
// under the License.
#include "arrow/flight/sql/odbc/tests/odbc_test_suite.h"

#ifdef _WIN32
# include <windows.h>
#endif
#include "arrow/flight/sql/odbc/odbc_impl/platform.h"

#include <sql.h>
#include <sqltypes.h>
#include <sqlucode.h>

#include "gtest/gtest.h"
#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
6 changes: 2 additions & 4 deletions cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,13 @@
// under the License.
#include "arrow/flight/sql/odbc/tests/odbc_test_suite.h"

#ifdef _WIN32
# include <windows.h>
#endif
#include "arrow/flight/sql/odbc/odbc_impl/platform.h"

#include <sql.h>
#include <sqltypes.h>
#include <sqlucode.h>

#include "gtest/gtest.h"
#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

Expand Down
Loading
Loading