Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to move to the previous/next SF2 into a same folder. #41

Open
Aleskis opened this issue Jun 27, 2022 · 4 comments
Open

Ability to move to the previous/next SF2 into a same folder. #41

Aleskis opened this issue Jun 27, 2022 · 4 comments

Comments

@Aleskis
Copy link

Aleskis commented Jun 27, 2022

Hi,

First of all, thank you for this nice player. Do you think it would be possible to add some kind of drop down list that would load the previous/next SF2 to navigate between files in the same folder. It would be comfortable to navigate this way, especially when an instrument has several articulations between several SF2.

Thanks a lot!

@Birch-san
Copy link
Owner

hmmm I'm not sure this would be possible on macOS (I have sandboxing enabled, to enable the app to be used without creating a security exclusion. I think the sandbox doesn't let us see the filesystem: instead it gives us a callback after the user finishes picking a file via the native filepicker).

it's also pretty unpredictable what the "next" file should be — what order would it be sorted by? I think an experience where "it doesn't matter; I'll just cycle until I find it" would be pretty bad, because opening SF3 soundfonts takes tens of seconds (you don't want to open one by accident).

it's also not obvious to me what the keyboard controls would be (I'm already using arrow keys for switching banks and presets, which is what you want convenient access to most of the time).

I think it's hard to implement this in a useful way. for my personal use-cases, I need fast access to changing banks/presets, but don't need fast access to changing soundfont file. can you access the file picker control via the keyboard? it's not quite the shortcut you asked for, but I think it's hard to get this down to one keypress due to the problems mentioned above.

@Aleskis
Copy link
Author

Aleskis commented Jun 28, 2022

Hi,

Ok, for MacOs, I understand the difficulty. In fact, this is a feature I liked in Sforzando (the only one). And I miss it in this player. Indeed, in a folder where I have very heavy banks, this way of navigating because of the loading time would not be adequate. But there are hundreds of small banks that load instantly for which this would be useful, I'm thinking in particular of the very numerous instruments in VSCO, which require that I load them one by one to determine if the soon is suitable for me.
For the file order, I would stick to a simple alphabetical sorting. For the keyboard shortcuts... Any of them will do, like P/N for preview/next. Or we could add alt in conjunction with the arrows (or opt for MacOs).
Anyway, it works well in Sforzando, so I was thinking that maybe juicysf could use it. After that, if you think it creates more problems than it solves, I'll bow out :)

@Birch-san
Copy link
Owner

loading time can be mitigated by implementing lazy-loading (main hurdle there is that it complicates the application architecture and save/loading, both of which are already really difficult to test).

and it's possible to make platform-dependent features. but macOS is the primary platform I target, so it's not super motivating for me to build functionality I cannot use.

it doesn't have to be me who builds it, of course. 😉

@Aleskis
Copy link
Author

Aleskis commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants