Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dataset_v1.2-DRAFT.json #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create Dataset_v1.2-DRAFT.json #672

wants to merge 1 commit into from

Conversation

ljgarcia
Copy link
Contributor

Add about as recommended.

In Bioschemas, following what is done in RO-Crate, about should be used to specified the nature of the content of the dataset, uisng DefinedTerm whenever possible. For instance, if a dataset contains information about mice, the about could be ncit:10090. Ideally this info should go as part of the Bioschemas description but currently there is no way to capture those.

This change is discussed in #629

Internal reference

e.g. https://github.com/BioSchemas/specifications/issues/596

Description

  • add about as recommended property

Motivation and context

In Bioschemas, following what is done in RO-Crate, about should be used to specified the nature of the content of the dataset, uisng DefinedTerm whenever possible. For instance, if a dataset contains information about mice, the about could be ncit:10090.

Have these been tested?

No

What should reviewers focus on?

Validity of the specification

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Future TO-DOs

  • Once reviewed, check webpage update

Add about as recommended.

In Bioschemas, following what is done in RO-Crate, about should be used to specified the nature of the content of the dataset, uisng DefinedTerm whenever possible. For instance, if a dataset contains information about mice, the about could be ncit:10090. Ideally this info should go as part of the Bioschemas description but currently there is no way to capture those. 

This change is discussed in #629
@ljgarcia ljgarcia requested a review from gtsueng April 12, 2024 16:21
"properties": {
"about": {
"description": " The subject matter of the content.",
"owl:cardinality": "many"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding the following validation to the validation for about to describe the expected value:

            "oneOf": [
                 {
                     "$ref": "#/definitions/thing"
                 },
                 {
                     "type": "array,
                     "items": {
                         "$ref": "#/definitions/thing"
                     }
                 }
             ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants