Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of HTTP errors in EUtils #14

Open
mirestrepo opened this issue Jul 13, 2018 · 0 comments
Open

Better handling of HTTP errors in EUtils #14

mirestrepo opened this issue Jul 13, 2018 · 0 comments

Comments

@mirestrepo
Copy link
Contributor

Expected Behavior

Handle EUtils HTTP errors gracefully

Current Behavior

Some HTTP errors throw rather cryptic errors. For instance if more NCBI's API frequency is exceeded (3 calls/seconds), we get an error

Got an exception of type HTTP.IOExtras.IOError outside of a @test
  IOError(EOFError() during request(https://eutils.ncbi.nlm.nih.gov/entrez/eutils/esummary...

Possible Solution / Implementation

Try/Catch, if error is of the right type, sleep(0.3) try again. We need to investigate if the HTTP error is consistent in this case
Alternatively, we could keep a global representing time since last call?

Steps to Reproduce (for bugs)

If the sleep(0.3) lines are taken out of tests, then they intermittently fail

ibacher added a commit to ibacher/BioServices.jl that referenced this issue Sep 4, 2019
This goes some way towards addressing BioJulia#14
ibacher added a commit to ibacher/BioServices.jl that referenced this issue Sep 4, 2019
This goes some way towards addressing BioJulia#14
ibacher added a commit to ibacher/BioServices.jl that referenced this issue Sep 4, 2019
This goes some way towards addressing BioJulia#14
ibacher added a commit to ibacher/BioServices.jl that referenced this issue Sep 4, 2019
This goes some way towards addressing BioJulia#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant