-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macos support for gamepads #188
base: main
Are you sure you want to change the base?
Conversation
Not your fault, but Windows support just broke. I'll merge this in once the issue is resolved. Not 100% sure on the cause, but it seems SDL and GitHub are looking into it:
If these issues get fixed, I will roll back my 3 commits here (those were to debug the issue) |
Marking this as a draft until we resolve the Windows issue and new MacOS issue |
Windows is working! But now there seems to be a new error on the MacOS builds: #import "Headers/flutter_sdl_gamepad-umbrella.h"
^
#import "SDL_egl.h"
^
/Users/runner/work/Dashboard/Dashboard/macos/Flutter/ephemeral/.symlinks/plugins/flutter_sdl_gamepad/macos/Frameworks/SDL3.framework/Headers/SDL_egl.h:36:10: error: 'EGL/egl.h' file not found
#include <EGL/egl.h>
^
<unknown>:0: error: could not build Objective-C module 'flutter_sdl_gamepad I'm not sure how or why this is suddenly different than previous builds. Logs show MacOS was working fine back in November, but we only added the SDL3 Framework files in December, so it seems this is GitHub's first time getting to run with SDL? But it looks like this run was using the Git version, which did have SDL support. I'm confused, so I filed libsdl-org/SDL#12038 to get some help |
Okay I managed to "fix" it by going back to the last commit in the To me, that means that XCode was possibly skipping those files before, and that's why this error is happening now, but I'm not 100% sure. |
Change the overrides after SDL3 merge (BinghamtonRover/flutter_sdl_gamepad#1)