Skip to content

Commit

Permalink
fix(Bulk Update): Only Validate Data for Current Item in Loop
Browse files Browse the repository at this point in the history
  • Loading branch information
arthurkirkosa committed Aug 20, 2024
1 parent ab53475 commit 353863f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/Http/Controllers/RepositoryUpdateBulkController.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function __invoke(RepositoryUpdateBulkRequest $request)
$repository = $request->repositoryWith($model);

return $repository
->allowToUpdateBulk($request)
->allowToUpdateBulk($request, $item)
->updateBulk(
$request,
$id,
Expand Down
18 changes: 13 additions & 5 deletions src/Repositories/ValidatingTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public static function validatorForUpdateBulk(RestifyRequest $request, $resource
})->toArray();

return Validator::make(
$plainPayload ?? $request->all(),
[$plainPayload] ?? $request->all(),
$on->getUpdatingBulkRules($request),
$messages
)->after(function ($validator) use ($request) {
Expand All @@ -191,13 +191,21 @@ protected static function afterValidation(RestifyRequest $request, $validator)
//
}

protected static function afterStoringValidation(RestifyRequest $request, $validator) {}
protected static function afterStoringValidation(RestifyRequest $request, $validator)
{
}

protected static function afterStoringBulkValidation(RestifyRequest $request, $validator) {}
protected static function afterStoringBulkValidation(RestifyRequest $request, $validator)
{
}

protected static function afterUpdatingValidation(RestifyRequest $request, $validator) {}
protected static function afterUpdatingValidation(RestifyRequest $request, $validator)
{
}

protected static function afterUpdatingBulkValidation(RestifyRequest $request, $validator) {}
protected static function afterUpdatingBulkValidation(RestifyRequest $request, $validator)
{
}

/**
* @return array
Expand Down

0 comments on commit 353863f

Please sign in to comment.