Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to jest: 24.7.1 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update to jest: 24.7.1 #6

wants to merge 1 commit into from

Conversation

6ewis
Copy link

@6ewis 6ewis commented May 1, 2019

After updating we get the following errors/warning that needed a proper fix - thus the updates in the codebase:

 - A "describe" callback must not return a value. Returning a value from "describe" will fail the test in a future version of Jest.

 - A "describe" callback must not return a promise.

 - Trace: The node type SpreadProperty has been renamed to SpreadElement

@6ewis 6ewis force-pushed the updateJest branch 3 times, most recently from 02f1764 to 6676889 Compare May 2, 2019 00:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 24

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.308%

Totals Coverage Status
Change from base Build 16: 0.2%
Covered Lines: 66
Relevant Lines: 68

💛 - Coveralls

@6ewis 6ewis changed the title fix: Not allowed to return promise update to jest: 24.7.1 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants