Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency installation in pyproject.toml for pip install #60

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Sep 3, 2024

Addressing the identical pip install problem addressed in diffpy/diffpy.structure#97 and merged
in diffpy/diffpy.structure#98

@sbillinge sbillinge merged commit 92248e0 into Billingegroup:main Sep 3, 2024
2 checks passed
@sbillinge
Copy link
Contributor

nicely done there.

We may want to keep track of which packages we have updated this way and which we haven't. Maybe make issues on all the packages so we can close them. We don't have to do that for this one.

@bobleesj bobleesj deleted the pyproject branch September 3, 2024 17:13
@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 3, 2024

nicely done there.

We may want to keep track of which packages we have updated this way and which we haven't. Maybe make issues on all the packages so we can close them. We don't have to do that for this one.

Yup will make issues all around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants