fix(desktop): avoid Windows capture stalls - #12
Open
SunkenInTime wants to merge 1 commit into
Open
Conversation
5 tasks
github-actions
Bot
added
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows
desktopCapturerpath requests thumbnails for every visible source. On the affected machine, Chromium's Windows Graphics Capture backend repeatedly waited five seconds for an uncapturable source, delaying the handoff before the spring animation could begin.Use xa11y's native region screenshot for direct Windows captures instead. The active window's DIP bounds and metadata remain authoritative, while macOS and Linux keep their existing capture paths.
Measured on Windows:
Verification:
vp run --filter @t3tools/desktop typecheckvp lintThe focused unit test is included. The local Windows
vp testrunner currently exits before suite registration withVitest failed to find the current suite; CI should provide the authoritative test result.Generated with Codex (GPT-5.6-sol).