Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Currency not recognised #24

Closed
boomam opened this issue Feb 16, 2022 · 8 comments
Closed

Base Currency not recognised #24

boomam opened this issue Feb 16, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@boomam
Copy link

boomam commented Feb 16, 2022

Hi,
I get the error -

"Invalid format, for a list of supported currencies see: https://cdn.jsdelivr.net/gh/fawazahmed0/currency-api@1/latest/currencies.json"
 

This occurs on both the crypto, and the base in the new GUI, despite both being correct.
I have tried several combinations of crypto types and bases, to no avail.
 
Is this a known issue?

@BigNocciolino
Copy link
Owner

BigNocciolino commented Feb 17, 2022

Yes, since the implementation of the fallback mechanism, I'm pushing the commit this afternoon, now I can not.

EDIT: after trying to configure a new device I noticed that it works well, I can see the value that are you trying insert?

@boomam
Copy link
Author

boomam commented Feb 17, 2022

Several were tried.
Base tried as usd, USD, eur, EUR, gbp, GBP
Crypto Currency was tried as, MYST, myst, 1eco, 1ECO,

Its worth noting as well, that the error around currency comes up above the box for both entry sections - it probably should be adjusted to only show on the base currency section, so as not to confuse things.

@BigNocciolino
Copy link
Owner

Hi, i noticed that you have linked the cryptonator site, the is no longer using the their API, since the recent problems.
Now the component uses the api provided by [fawazahmed0](https://github.com/fawazahmed0/currency-api).

To see the available currencies go here.

Its worth noting as well, that the error around currency comes up above the box for both entry sections - it probably should be adjusted to only show on the base currency section, so as not to confuse things.

Yes, now the component shows the problems for each the boxes, I'm going to fix this.

@BigNocciolino BigNocciolino added the bug Something isn't working label Feb 18, 2022
@BigNocciolino BigNocciolino self-assigned this Feb 18, 2022
@boomam
Copy link
Author

boomam commented Feb 18, 2022

Hi, i noticed that you have linked the cryptonator site, the is no longer using the their API, since the recent problems. Now the component uses the api provided by [fawazahmed0](https://github.com/fawazahmed0/currency-api).

To see the available currencies go here.

Hi,
That currency list doesn't list the cryptos to convert from, just country currencies.

If the API call to get the crypto is no longer the one referenced, can you link to the crypto currency list that will work?

Thanks!

@BigNocciolino
Copy link
Owner

Hello, in that link there are also cryptocurrencies, only they are the most common ones, as fawazahmed0 points out in the documentation. Unfortunately, there is nothing I can do about it. Also, write crypto codes lowecase

@boomam
Copy link
Author

boomam commented Feb 20, 2022

Tried lower case (shown in example text above).

I searched the list, And he only shows a few common ones, like Bitcoin.

Is there a way to revert the plugin to an older one with greater currency compatibility?
As right now it's not useful unless you are using a few of the big ones, whereas pre-update it worked with a much larger set of crypto currencies.

BigNocciolino added a commit that referenced this issue Feb 21, 2022
@MilitaryNerd
Copy link

Agree with boomam above...I want to track my altcoins and this listly is mostly main coins, so not entirely useful and more of a novelty.

@BigNocciolino
Copy link
Owner

Hi, I talked with the owner of the api about the missing of some coins, he told me that every issue/PR is welcome to add new coins.

So you simply need to go to the api page

@BigNocciolino BigNocciolino closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants