docs(#75): add decision-level reference doc + expand schema comment#79
Merged
Knapp-Kevin merged 1 commit intoApr 28, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Knapp-Kevin
changed the base branch from
claude/codegenome-phase-1-2-qor
to
dev
…a comment The `decision_level` field on `decision` controls the L1 exemption guard in `handlers/bind.py` — but it was previously documented only inline in spec-governance-feedback.md and a terse 2-line schema comment. New contributors couldn't find the contract. Changes: - New `docs/decision-level.md` — single canonical reference for the field. Documents all four values (L1/L2/L3/NULL), their codegenome write semantics, the tolerant-NULL policy rationale, where the value comes from, and the read APIs. - `ledger/schema.py` — expanded comment block above the DEFINE FIELD, pointing to the new doc and giving a quick-reference value table. - `docs/spec-governance-feedback.md` §6 — updated follow-up table to reflect that BicameralAI#75/76/77/78 have all been filed and BicameralAI#75 is addressed by this commit. No code change. ASSERT constraint unchanged. All 5 L1-exemption tests still pass.
Knapp-Kevin
force-pushed
the
fix/75-document-decision-level
branch
from
8c24beb to
ea8fbc8
Compare
Knapp-Kevin
added a commit
that referenced
this pull request
Apr 28, 2026
The new dev integration workflow ("everything pushes and merges to dev
first, then PRs from dev to main upon Jin's approval") needs CI to run
on PRs targeting dev — not just main. Without this, retargeted PRs
(#73, #79–#84) never get a green badge and have to be merged on local
verification only.
Updates 3 workflows: MCP Regression Tests, Preflight Eval, Schema
Persistence. All other path filters retained.
Direct push to dev (not via PR) — no CI exists yet to run on this
file's own PR (chicken-and-egg). Subsequent PRs to dev will inherit
the new triggers.
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75.
Summary
The
decision_levelfield ondecisioncontrols the L1 exemption guard inhandlers/bind.py(added in #71/#59). It was previously documented only inline indocs/spec-governance-feedback.mdand a terse 2-line schema comment, so new contributors had no canonical place to look up valid values or write semantics.This PR adds that canonical place.
Changes
docs/decision-level.md— single reference for the field. Covers:L1,L2,L3,NULL) with their codegenome-write semanticsledger.queries.get_decision_level, adapter wrapper)ledger/schema.py— expanded the comment block aboveDEFINE FIELD decision_levelfrom 2 lines to a full quick-reference table that points at the new doc.docs/spec-governance-feedback.md§6 — follow-up table updated: all four new items (Docs: documentdecision_levelfield ondecisiontable in ARCHITECTURE_PLAN.md #75/76/77/78) now show as filed; Docs: documentdecision_levelfield ondecisiontable in ARCHITECTURE_PLAN.md #75 row marks itself addressed by this PR.Stacking
Stacked on
claude/codegenome-phase-1-2-qor(PR #71). Will rebase tomainonce #71 lands.Verification
python -c \"import ast; ast.parse(open('ledger/schema.py').read())\"— cleanpytest tests/test_codegenome_l1_exemption.py— 5/5 passTest plan
docs/decision-level.mdcold and confirms the four-value table is unambiguous