docs: refresh test + root READMEs (20-tool surface, retired mocks, e2e shelving)#565
Conversation
…e shelving) - tests/README.md: correct the stale tool surface (was "4 tools" / "5 registered tool names") to the real 20-tool registry — 18 bicameral.* ledger/session tools + the 2 code-locator primitives (validate_symbols, get_neighbors) — and point at EXPECTED_TOOL_NAMES in server.py as the drift-proof source of truth. Drop the retired-mock framing and the dead test_phase0_mocks.py reference; fix install to `pip install -e ".[test]"`; add sociable-testing + "what CI runs" sections. - README.md: add two truthful CI badges (lint+types, secret-scan — both present on main) and a gold-standard "at a glance" overview table. No existing prose rewritten. - tests/e2e/README.md: reflect the #556 shelving (workflow is dispatch-only, no longer a PR gate; replacement RFQ #555) and correct "six" -> five automated flows (1-5). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 59 minutes and 56 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughDocumentation updates across three README files establish project maturity/footprint visibility, restructure MCP regression test guidance around phase-gated real-adapter testing with environment toggles, and document the shelved e2e user-flow suite's transition to manual dispatch. ChangesTesting & Project Documentation
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/README.md`:
- Line 45: Update the README table entry for SURREAL_URL to match the test
fixture default: change the default value from
`surrealkv://~/.bicameral/ledger.db` to `memory://` so it aligns with the
`SURREAL_URL` default used in the test fixture (see conftest's SURREAL_URL
default); ensure the description still notes that `memory://` is for in-process
tests with no persistence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bb9cdb25-2094-463d-bd7f-ac3bad0ead1b
📒 Files selected for processing (3)
README.mdtests/README.mdtests/e2e/README.md
What
Documentation accuracy refresh for three READMEs, reconciled against current
main(post-split, post-#556).tests/README.md— corrects a live drift onmain: it claimed "all 4 tools" / "prints the 5 registered tool names", but the server registers 20 (EXPECTED_TOOL_NAMES: 18bicameral.*ledger/session tools + the 2 code-locator primitivesvalidate_symbols/get_neighbors). Now points atEXPECTED_TOOL_NAMESas the drift-proof source of truth. Also drops the retired-mock framing + deadtest_phase0_mocks.py, fixes the install topip install -e ".[test]", and adds sociable-testing + "what CI runs" sections.README.md— adds two truthful CI badges (lint+types, secret-scan — both workflows exist onmain) and a gold-standard "at a glance" overview table. No existing prose rewritten.tests/e2e/README.md— reflects the ci: shelve v0 e2e workflow — dispatch-only, remove PR trigger #556 shelving (workflow is dispatch-only, no longer a PR gate; it previously called itself "the canonical CI test"), points to the replacement RFQ RFQ: replacement e2e validation strategy for v0 user flows #555, and corrects "six" → five automated flows (1–5).Why
Docs-as-contract: the
tests/READMEtool count was ~4× off and referenced a retired subsystem; the e2e README advertised PR triggers that #556 removed. No code or governance artifacts touched.Refs
🤖 Generated with Claude Code
Summary by CodeRabbit