fix(hooks): #170 — gate the post-preflight capture reminder to non-read-only prompts

[Knapp-Kevin]

Closes #170.

Problem

The PostToolUse hook on bicameral_preflight fired the Step 5.6 capture-disambiguation reminder on every preflight that surfaced ≥1 decision — including read-only, compatible, and tangential prompts where no refinement exists. That spams the user with AskUserQuestions and risks spurious/hallucinated captures.

Fix — read-only-only suppression gate

suppress_capture_reminder(prompt) (in scripts/hooks/preflight_intent.py) suppresses the reminder only for unambiguously read-only/informational prompts that carry no implementation verb. The UserPromptSubmit hook hands the prompt to the PostToolUse hook via a session-scoped store (scripts/hooks/session_prompt_store.py; 24h staleness sweep + SessionEnd cleanup).

⚠️ Design decision (operator-ruled after an audit VETO) — please read

An initial recall-biased lexical gate (suppress on a 'compatible' keyword absent a contradiction keyword) was VETOed in audit: it reintroduces the exact #175 failure mode. A lexical scan cannot distinguish a truly-compatible prompt (add tests for X) from a refinement smuggled under a compatible verb (add tests for X, and expose it as a programmatic API) — suppressing the latter is silent, irreversible decision-capture loss.

Decision: the gate fails open on ANY implementation verb — only verb-free read-only prompts are ever suppressed. This structurally preserves the #175 invariant (contradiction is never decided by a lexical scan over a write prompt).

Consequence — acceptance case (b) is intentionally NOT implemented: add tests for drag-to-reorder carries add, so it fires (not suppressed). The issue's acceptance should be amended to "suppress read-only/informational prompts only." Suppressing compatible writes is not safely achievable lexically; it would require a non-lexical signal (e.g. an explicit user toggle) — out of scope here.

Tests (lock the invariant)

• tests/test_preflight_intent.py — incl. the feat(skill): user-disambiguation question before Step 5.6 contradiction capture #175 regression guard: add tests … expose as a programmatic API → must fire; a non-add verb variant (locks the regex, not the literal); contradiction prompt → not suppressed; read-only → suppressed.
• tests/test_post_preflight_capture_reminder.py — drives the real hook main() for the 3 acceptance fixtures + recall-bias fallback (missing prompt → fire) + store round-trip / 24h sweep / SessionEnd cleanup.
• 19 Reduce collision-capture reminder spam from PostToolUse hook on bicameral_preflight #170 tests + 25 adjacent hook tests green locally; ruff check + format clean; skill-governance lint 22/22.

Governance

• Risk L2 (advisory hook, exit 0; correctness risk — silent capture loss — structurally eliminated by fail-open-on-verb). No ledger/schema.py change.
• Governed via /qor-auto-dev-1: plan → audit VETO → re-plan (operator ruling) → re-audit PASS → implement → substantiate.
• META_LEDGER seal deferred to merge — this branch and feat(ingest): #404 Phase 1 — thread parent_decision_id through natural-format ingest #534 both branch off dev tip Entry feat: v0.7.1 — bicameral-capture-corrections + SessionEnd hook via setup #55; sealing here would fork the Merkle chain against feat(ingest): #404 Phase 1 — thread parent_decision_id through natural-format ingest #534's pending Entry desync optimization V1 — read-path advisory + V2 implementation guide #56. Sealed (next free entry, re-chained) at merge.
• skills/bicameral-preflight/SKILL.md Step 5.6 updated to document the gate (Tool/Skill-contract rule).

🤖 Authored via Qor-logic SDLC on Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6d5a8ad-ba9e-4be0-a73f-a6d0ccf11128

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/170-preflight-capture-reminder-gate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jinhongkuan]

Closing during PR hygiene because this branch is stale/conflicting and predates the alpha review-routing docs. The underlying UX point is still relevant for cognitive-debt reduction: read-only prompts should not trigger write/capture pressure. Please re-cut from current dev against issue #170 and align with the alpha model where Product Owner review is implicit and reason explains routing, not reviewer assignment.