feat(handlers): telemetry write handlers routed through DaemonProxy (Phase 2c-6a)#511
Merged
Merged
Conversation
…Phase 2c-6a) Split handle_feedback / handle_skill_begin / handle_skill_end into thin MCP-side facades + _impl cores. Facades delegate to ctx.daemon when available; fall through to in-process impl on any error. Server-side dispatchers in protocol/handlers/writes.py updated to call _impl directly to avoid infinite RPC loops. DaemonProxy gains feedback, skill_begin, skill_end methods mirroring history's shape. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jinhongkuan
requested a deployment
to
recording-approval
GitHub Actions
Waiting
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…mmary method) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jinhongkuan
requested a deployment
to
recording-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2c-6a — migrate the three telemetry-only write handlers (handle_feedback, handle_skill_begin, handle_skill_end) to route through the daemon. Server-side dispatchers in
protocol/handlers/writes.pyalready wired by #503; this PR migrates the call-sites and adds boundary tests.Telemetry writes are first in the 2c-6 sequence because they don't mutate the ledger — pure PostHog events. Concurrency / single-writer / destructive-write boundary work lands in 2c-6b/c/d.
Plan refs
thoughts/shared/plans/2026-05-22-daemon-as-process-arc.mdTest plan
pytest tests/test_telemetry_writes_via_daemon.py— boundary tests through real daemon subprocessruff format --check . && ruff check .clean🤖 Generated with Claude Code