docs(dev-cycle): §4.7 expand-only + flag-gate, amend §10.5.1 triage eligibility#389
Merged
Merged
Conversation
… (triage eligibility) Encodes the three architectural decisions ratified 2026-05-15 (decision:cp25jfz1nt6h3u2gjzmu, decision:adklplvfhthkdch05pe9, decision:0ok1249n2tdrfud2a5j9): §4.7 — new subsection enforcing two complementary rules for any PR that touches ledger/schema.py or its _MIGRATIONS registry: §4.7.1 — schema migrations must be expand-only. Destructive operations (REMOVE / DROP / breaking ALTER / tightening ASSERT) live in their own commits and ship in a later release after the prior reader surface is validated as gone from prod. Includes an allowed/forbidden table for reviewer ease. CI lint planned via scripts/lint_schema_destructive.py. §4.7.2 — code paths that depend on new schema must be feature-flag gated and default OFF in prod (env var or .bicameral/config.yaml setting). Schema ships immediately; flag flips later in a separate release. If the experiment is killed, the flag never flips on and a follow-up cleanup migration drops the slot. Exception: invariant bugfixes (e.g. fixing a unique-index collision that breaks the dashboard for everyone) don't need flag-gating — that's not feature surface. §4.7.3 — concrete PR-review checklist for schema-touching PRs. §10.5.1 — triage eligibility rule rewritten. Previously: "schema-migrating changes are not triage-eligible" (blanket). Now: schema migrations CAN ride a triage release if they comply with §4.7 (expand-only AND feature code is flag-gated). The blanket ban is replaced by enumerated exclusions (destructive schema, flag-flip releases, breaking public-API changes, multi-PR epics, v1 patches). Motivation: the prior rule was correct under the implicit assumption that schema and feature ship together — then you can't ship one without the other. Once §4.7 decouples them, schema can drain to main on every triage instead of accumulating on dev waiting for a "real" release. The current v18→v24 backlog (drained by the v0.15.0 release PR #388) is the symptom the prior rule produced; this amendment prevents recurrence. Refs decision:cp25jfz1nt6h3u2gjzmu, decision:adklplvfhthkdch05pe9, decision:0ok1249n2tdrfud2a5j9. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jinhongkuan
added
the
flow:feature
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jinhongkuan
pushed a commit
that referenced
this pull request
May 16, 2026
Introduces .github/CODEOWNERS to enforce the §4.7 expand-only + flag-gate discipline at PR time. Pairs with the dev branch-protection update (require_code_owner_reviews: true) landed alongside. Initial scope is minimal — only ledger/schema.py. The migration registry (_MIGRATIONS) and SCHEMA_VERSION live in that file, so every schema-chain change routes through Jin's review. Caveat: @jinhongkuan-authored PRs touching ledger/schema.py will still need a second reviewer (GitHub does not let users approve their own PRs) or an admin override. That's the spirit of the rule — schema changes warrant explicit second-pair-of-eyes attention regardless of author. Refs DEV_CYCLE.md §4.4 (Reviewers) and §4.7 (Schema-touching PRs — expand-only + flag-gate). #389 is the doctrine PR that introduces §4.7; this PR enforces it mechanically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ledger/schema.pyor its_MIGRATIONSregistry: migrations must be additive only (destructive ops live in dedicated later-release commits), and code paths that depend on new schema must be feature-flag gated default-off in prod.Linked issues
No tracked issue — doctrine amendment surfaced during the v0.15.0 release planning (PR #388), where the existing rule blocked a
v17 → v24migration chain from ever reaching main through triage and forced an all-or-nothing full release.Linked decisions
Closes decision:cp25jfz1nt6h3u2gjzmu — Schema migrations must be expand-only; destructive ops live in dedicated commits.
Closes decision:adklplvfhthkdch05pe9 — Code paths depending on new schema must be feature-flag gated, default off in prod.
Closes decision:0ok1249n2tdrfud2a5j9 — DEV_CYCLE.md §10.5.1 (triage eligibility) amended: triage releases CAN carry schema migrations when (a) every migration is expand-only and (b) every feature is flag-gated.
Plan / Audit / Seal
docs/DEV_CYCLE.md. No code, no behavior change. Rules apply prospectively to PRs landing after this merges.Backwards compatibility with current state
Test plan
markdownlint docs/DEV_CYCLE.mdwould catch syntax issues (not currently run in CI — verified by inspection).pr-body-refs-lint.yml) checksCloses #N/Closes decision:…formatting in this PR body.Follow-up work (not in this PR)
scripts/lint_schema_destructive.py— CI gate that parsesledger/schema.pydiffs and flagsREMOVE/ breakingALTER/ tightening-ASSERT operations in any commit that also modifies non-migration code. §4.7.1 references this as planned. Separate PR with a tracked issue._MIGRATIONSchain on dev (v17 → v24) against §4.7.1 retrospectively — most are already additive, but the audit produces a clean baseline for future "every migration in the chain since vN complies with §4.7" claims.🤖 Generated with Claude Code