Skip to content

docs(dev-cycle): require linked bicameral decision on org-member PRs#384

Merged
jinhongkuan merged 1 commit into
devfrom
docs/dev-cycle-require-linked-decision
May 16, 2026
Merged

docs(dev-cycle): require linked bicameral decision on org-member PRs#384
jinhongkuan merged 1 commit into
devfrom
docs/dev-cycle-require-linked-decision

Conversation

@jinhongkuan

Copy link
Copy Markdown
Contributor

Summary

  • Adds a ## Linked decisions section to the §4.3 PR body template, parallel to ## Linked issues.
  • Codifies the rule: every PR authored by a BicameralAI org member references at least one decision:<surrealdb-id>.
  • External contributors are exempt — the shepherding maintainer ingests the decision on their behalf at merge time.

Why

The PR body already tells reviewers what changed and which issue it closes; the bicameral ledger tells us which decision it satisfies. Today the link between the two is implicit (a reviewer either knows the decision exists or they don't). Making it explicit:

  • Forces the author to verify the change actually traces to an ingested decision before opening the PR (catches "drift via PR" — code that lands ahead of the decision-of-record).
  • Gives reviewers a concrete artifact to verify against, alongside the linked issue.
  • Closes the loop with bicameral.preflight — preflight surfaces the decision; the PR cites it; the post-commit sync resolves compliance against it.

External contributors are exempt because bicameral access is org-internal. Gating community PRs on internal tooling is the wrong tradeoff; a maintainer ingesting on their behalf at merge time keeps the audit trail intact without exporting our internal substrate.

Linked issues

(none — this is a process change that doesn't close a specific issue)

Linked decisions

(meta: this PR's own linked-decision section is empty by intent — the decision codified here was made in conversation today and ingestion is blocked by an unrelated MCP-server outage on the dev box. Will ingest + back-link in a follow-up comment once the MCP server is restored.)

Plan / Audit / Seal

  • Plan: trivial; risk:L1 (doc-only rule addition, no CI enforcement yet)

Test plan

  • Visual review of docs/DEV_CYCLE.md §4.3 diff — template renders correctly in GitHub markdown.
  • No code paths touched; existing CI suites are sufficient.

Out of scope

  • CI lint that enforces a decision:<id> token in org-member PR bodies. Worth doing if compliance slips, but the doctrine update lands first so reviewers can hold the line manually.
  • Updating the GitHub PR template (.github/pull_request_template.md) — that file doesn't exist yet; if/when it's added, mirror the §4.3 template.

🤖 Generated with Claude Code

Adds a ## Linked decisions section to the §4.3 PR body template,
parallel to ## Linked issues, and codifies the rule: every PR
authored by a BicameralAI org member references at least one
decision:<surrealdb-id> so reviewers can verify the change is
grounded in an explicit decision rather than ambient assumption.

External contributors are exempt — bicameral access is org-internal,
and gating community PRs on internal tooling is the wrong tradeoff.
The reviewing maintainer shepherds the decision ingest on the
contributor's behalf at merge time.

This is a doc-only rule; CI enforcement (lint that an org-member PR
body contains a decision:<id> token) can follow as a separate PR if
needed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jinhongkuan jinhongkuan added P2 Medium: next milestone or two; default for new issues post-triage governance docs Documentation-only change docs-only Documentation-only surface labels May 16, 2026
@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: befa8013-f6a4-42b2-8fa7-04ca32ff3457

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/dev-cycle-require-linked-decision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jinhongkuan jinhongkuan enabled auto-merge May 16, 2026 03:11
@jinhongkuan jinhongkuan merged commit 27a6500 into dev May 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation-only change docs-only Documentation-only surface governance P2 Medium: next milestone or two; default for new issues post-triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant