docs(dev-cycle): require linked bicameral decision on org-member PRs#384
Merged
Conversation
Adds a ## Linked decisions section to the §4.3 PR body template, parallel to ## Linked issues, and codifies the rule: every PR authored by a BicameralAI org member references at least one decision:<surrealdb-id> so reviewers can verify the change is grounded in an explicit decision rather than ambient assumption. External contributors are exempt — bicameral access is org-internal, and gating community PRs on internal tooling is the wrong tradeoff. The reviewing maintainer shepherds the decision ingest on the contributor's behalf at merge time. This is a doc-only rule; CI enforcement (lint that an org-member PR body contains a decision:<id> token) can follow as a separate PR if needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
## Linked decisionssection to the §4.3 PR body template, parallel to## Linked issues.decision:<surrealdb-id>.Why
The PR body already tells reviewers what changed and which issue it closes; the bicameral ledger tells us which decision it satisfies. Today the link between the two is implicit (a reviewer either knows the decision exists or they don't). Making it explicit:
bicameral.preflight— preflight surfaces the decision; the PR cites it; the post-commit sync resolves compliance against it.External contributors are exempt because bicameral access is org-internal. Gating community PRs on internal tooling is the wrong tradeoff; a maintainer ingesting on their behalf at merge time keeps the audit trail intact without exporting our internal substrate.
Linked issues
(none — this is a process change that doesn't close a specific issue)
Linked decisions
(meta: this PR's own linked-decision section is empty by intent — the decision codified here was made in conversation today and ingestion is blocked by an unrelated MCP-server outage on the dev box. Will ingest + back-link in a follow-up comment once the MCP server is restored.)
Plan / Audit / Seal
Test plan
docs/DEV_CYCLE.md§4.3 diff — template renders correctly in GitHub markdown.Out of scope
decision:<id>token in org-member PR bodies. Worth doing if compliance slips, but the doctrine update lands first so reviewers can hold the line manually..github/pull_request_template.md) — that file doesn't exist yet; if/when it's added, mirror the §4.3 template.🤖 Generated with Claude Code