seal(#218 LLM-06): META_LEDGER entry #44 — skills manifest signing substantiated#251
Merged
Merged
Conversation
…bstantiated Out-of-band substantiation: implementation already merged to dev via PR #249 (merge commit b2fc66e); this ledger-only commit lands the seal entry off dev tip. Closes #214 (#218 sub-task LLM-06 — sign skills/ payload). Closes #218 epic (6/6 sub-tasks complete). Reality matches Promise: 11 planned files committed (3 phases of plan-F); 14 new functional tests (7 generator + 7 verifier; 2 generator tests beyond plan-F enumeration for stronger contract coverage) plus 1 content-contract test extension all PASS. Wheel-build smoke test verified skills-manifest.toml ships at hatch shared-data location alongside hooks-manifest.json. Logged deviation: build-hook consolidated deeper than the audit's Path A — single ManifestsBuildHook class generating both manifests in one initialize, per hatch's actual one-class-per-registered-module constraint. Same auto-discovery semantics; cleaner module structure. Cosign keyless signing of skills-manifest.toml mirrors #237 LLM-11 pipeline; deferred sigstore-python verifier wiring activates both manifests together when it lands. Plan: plan-F-llm-06-skills-manifest-signing.md Audit: round 2 PASS (round-1 infrastructure-mismatch VETO cleared).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Out-of-band substantiation seal for #218 LLM-06. Implementation already shipped via PR #249 (merged to
devasb2fc66eon 2026-05-07T06:38:18Z). This ledger-only PR carries the corresponding META_LEDGER entry #44 — the canonical substantiation record that PR #249's body and code did not append to the chain.Closes the chain gap that opened when the implementation PR merged before the substantiation pass ran.
What this PR contains
docs/META_LEDGER.md(+95 lines, entry [P2] LLM semantic drift judge: suppress false-positive drift flags on cosmetic code changes #44 appended)Reality vs Promise (recap from entry #44)
11/11 planned files from
plan-F-llm-06-skills-manifest-signing.mdshipped via PR #249. 14 new functional tests all PASS (7 generator + 7 verifier; 2 generator tests beyond plan-F enumeration). Wheel-build smoke test confirmedskills-manifest.tomllands at the proper hatch shared-data location alongsidehooks-manifest.json.Logged deviation
The audit's Path A specified two
BuildHookInterfacesubclasses in one registered module. Implementation discovered hatch's actual one-class-per-module constraint and consolidated further into a singleManifestsBuildHookwhoseinitializegenerates both manifests in one pass. Same auto-discovery semantics; cleaner structure. Captured in entry #44's "Logged deviations" section.Closes
Test plan
devtipb2fc66eFuture-doctrine note
Entry #44 includes a "Timing note (out-of-band substantiation)" section flagging the same split that produced #42/#43 — future #218-class seals should bundle the implementation + seal entries in a single PR per the doctrine when feasible.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com