test(e2e): Flow 1 asserter feature-area relax + Bash post-commit hook envelope

[jinhongkuan]

Bundles two independent fixes that together stabilize the e2e job on `dev`:

1. Flow 1 asserter relaxed — exact-filename gate (`reorder.ts` AND `cherry-pick.ts` both bound) replaced with a feature-area gate (any file in the relevant area counts as a legitimate anchor). Fixes the LLM-nondeterminism flake where the agent picks UI-layer `commit-list.tsx` instead of git-layer `reorder.ts` for the bundled drag-to-reorder/squash/amend/branch-from decision.

2. Bash post-commit PostToolUse hook now uses hookSpecificOutput envelope — the inline `python3 -c` one-liner in `setup_wizard.py` printed "bicameral: new commit detected …" to plain stdout, which Claude Code 2.x silently drops to the debug log (per https://code.claude.com/docs/en/hooks). Symptom: the agent commits in Flow 3 but never follows through with `link_commit` because the reminder never reached the model. Fix: move the inline command to a proper script file emitting `{hookSpecificOutput: {hookEventName: "PostToolUse", additionalContext: "..."}}`.

Originally opened as PRs #171 + #169; combined here per request.

Why bundle

Both changes are needed for Flow 3's ledger assertion to reliably PASS:

• Asserter relax stops Flow 1 from cascading into Flow 3 when the agent picks a non-canonical anchor.
• Bash hook envelope makes the agent reliably call `link_commit` after Flow 3's git commit so compliance_check rows actually get written.

Either one in isolation could still red-light the e2e job; together they remove both flake sources from the post-Flow-2a gauntlet.

What's in this PR

Flow 1 asserter (`tests/e2e/run_e2e_flows.py`)

Each seeded decision must have ≥1 bound path matching one of an acceptable substring set:

• cherry-pick area: `cherry-pick.ts`, `cherry-pick.tsx`
• commit-history area: `/git/reorder.ts`, `/git/squash.ts`, `/git/commit.ts`, `/history/commit-list.tsx`, `/history/commit-list-item.tsx`, `/multi-commit-operation/{reorder,squash}.tsx`, `/dispatcher/dispatcher.ts`, `/models/{multi-commit-operation,retry-actions}.ts`, `/stores/app-store.ts`

Asserter unit tests (`tests/test_e2e_asserters.py`)

8 cases — canonical `reorder.ts`, UI-layer `commit-list.tsx` (previously flaky), dispatcher / squash anchors, `cherry-pick.tsx`, negative cases (unrelated file → fail with clear `commit-history area` / `cherry-pick area` detail), missing ratify.

Post-commit hook (`scripts/hooks/post_commit_sync_reminder.py`)

Reads `{tool_name, tool_input}` from stdin; if `tool_name == Bash` and the command contains `git commit` / `git merge ` / `git pull` / `git rebase --continue`, emits the envelope. Reminder text preserves the canonical "bicameral: new commit detected" prefix verbatim so the `bicameral-sync` skill's existing trigger keeps matching.

Hook unit tests (`tests/test_post_commit_sync_hook.py`)

11 cases — each git write-op verb, read-only git, non-Bash tool, non-git Bash, malformed stdin, missing/non-dict `tool_input`, idempotent.

Wiring

• `pyproject.toml` — `bicameral-mcp-post-commit-sync-reminder` console script.
• `setup_wizard.py` — `_BICAMERAL_POST_COMMIT_COMMAND` now references the console script. Existing `_install_claude_hooks` merge logic unchanged.
• `.claude/settings.json` — dogfood entry invokes the source script via `python3`.

Validation

• `ruff check .` — clean (217 files).
• `ruff format --check .` — clean (217 files).
• `pytest tests/test_e2e_asserters.py tests/test_post_commit_sync_hook.py tests/test_preflight_hook.py` — 24/24 PASS.
• Setup-wizard byte-stability across repeated `_install_claude_hooks` calls.

Test plan

• CI: `e2e assertions (auto)` — Flow 1 PASSes regardless of which feature-area file the agent picked; Flow 3 ledger assertion (compliance_check rows written) reliably PASSes.
• CI: `ruff + mypy` passes.
• CI: `MCP Regression Suite` (ubuntu + windows) passes.

Companion PR

#168 — adds the resolve_collision PostToolUse hook for Flow 2a (#154), bumps the 300s flow timeout, and uses the same envelope shape this PR establishes for the Bash hook.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53d0c196-6322-4566-a47e-87b2dfc4e485

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/flow1-asserter-relax-feature-area

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}