fix(ci): clear ruff failures on dev post-#96 merge#105
Merged
Knapp-Kevin merged 1 commit intoApr 29, 2026
Conversation
PR BicameralAI#96 (preflight eval phase 3 — real-I/O C2/C3) merged before the ruff+mypy CI Phase 1 gate (PR BicameralAI#102) flagged its lint failures. Result: dev's lint check is currently red, blocking every subsequent PR's CI. This commit applies `ruff check --fix` + `ruff format` to: - tests/eval/ (4 files reformatted, 7 auto-fixes — import sort, f-string trims, etc.) - tests/test_ephemeral_authoritative.py (1 fix — F541 f-string without placeholder; pre-existing on Silong's branch, came through the merge auto-resolution unchanged) No behavioural changes; no test logic changes. Pure lint hygiene to unblock CI. Validates locally: ruff check passes, full eval test suite unchanged (35/35 in test_cost_baseline_helpers.py).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fast-follow lint hygiene PR after PR #96 (preflight eval phase 3 — real-I/O C2/C3) merged with ruff failures still on its HEAD. Dev's CI Phase 1 `ruff + mypy` check is currently red on `5f773e6`; this PR clears it.
Why
Timeline:
This PR re-applies the same fixes directly against current dev HEAD.
What changed
8 auto-fixes total, 5 files reformatted, zero behavioural changes.
Linked
Refs #96 (the merge that introduced the regression), #102 (the CI gate that caught it).
Test plan
Plan / Audit / Seal
Plan: trivial; risk:L1 (lint hygiene only; no behavioural code paths).