Skip to content

fix(ci): clear ruff failures on dev post-#96 merge#105

Merged
Knapp-Kevin merged 1 commit into
BicameralAI:devfrom
Knapp-Kevin:fix/96-followup-ruff-fixes
Apr 29, 2026
Merged

fix(ci): clear ruff failures on dev post-#96 merge#105
Knapp-Kevin merged 1 commit into
BicameralAI:devfrom
Knapp-Kevin:fix/96-followup-ruff-fixes

Conversation

@Knapp-Kevin

Copy link
Copy Markdown
Collaborator

Summary

Fast-follow lint hygiene PR after PR #96 (preflight eval phase 3 — real-I/O C2/C3) merged with ruff failures still on its HEAD. Dev's CI Phase 1 `ruff + mypy` check is currently red on `5f773e6`; this PR clears it.

Why

Timeline:

  1. PR Preflight eval phase 3 — real-I/O C2/C3 measurement (Jin's review feedback) #96 was retargeted from main → dev and rebased to resolve 19 conflicts.
  2. The ruff+mypy CI Phase 1 gate (PR chore: CI Phase 1 — Windows matrix + ruff/mypy + secret scan + merged-to-dev labeller #102) flagged 8 lint issues on the merged SHA `6bf4a91`.
  3. I pushed lint fixes to PR Preflight eval phase 3 — real-I/O C2/C3 measurement (Jin's review feedback) #96's branch (`f052421`, `956d5ef`, `e111860`) but the squash-merge had already executed at `6bf4a91` before those landed.
  4. Dev now has the lint issues, blocking every subsequent PR's CI.

This PR re-applies the same fixes directly against current dev HEAD.

What changed

File Fix
`tests/eval/_baseline_io.py` ruff format (4 lines)
`tests/eval/run_preflight_cost_eval.py` ruff format (line wrapping)
`tests/eval/test_cost_baseline_helpers.py` I001 import sort + format
`tests/eval/_seed_ledger.py` ruff format
`tests/test_ephemeral_authoritative.py` F541 — `f"..."` with no placeholder → `"..."`

8 auto-fixes total, 5 files reformatted, zero behavioural changes.

Linked

Refs #96 (the merge that introduced the regression), #102 (the CI gate that caught it).

Test plan

  • `ruff check tests/eval/ tests/test_ephemeral_authoritative.py` — all checks passed
  • `ruff format --check` — clean
  • `pytest tests/eval/test_cost_baseline_helpers.py -q` — 35/35 passed (unchanged behaviour)

Plan / Audit / Seal

Plan: trivial; risk:L1 (lint hygiene only; no behavioural code paths).

PR BicameralAI#96 (preflight eval phase 3 — real-I/O C2/C3) merged before
the ruff+mypy CI Phase 1 gate (PR BicameralAI#102) flagged its lint failures.
Result: dev's lint check is currently red, blocking every
subsequent PR's CI.

This commit applies `ruff check --fix` + `ruff format` to:
- tests/eval/ (4 files reformatted, 7 auto-fixes — import sort,
  f-string trims, etc.)
- tests/test_ephemeral_authoritative.py (1 fix — F541 f-string
  without placeholder; pre-existing on Silong's branch, came
  through the merge auto-resolution unchanged)

No behavioural changes; no test logic changes. Pure lint hygiene
to unblock CI.

Validates locally: ruff check passes, full eval test suite
unchanged (35/35 in test_cost_baseline_helpers.py).
@Knapp-Kevin Knapp-Kevin added the flow:feature Standard feature/fix PR targeting BicameralAI/dev (the default flow) label Apr 29, 2026
@Knapp-Kevin Knapp-Kevin requested a review from jinhongkuan April 29, 2026 17:34
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2c8a2c22-c66c-4ea7-bcd2-72855dcb75f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Knapp-Kevin Knapp-Kevin merged commit f72e2a4 into BicameralAI:dev Apr 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flow:feature Standard feature/fix PR targeting BicameralAI/dev (the default flow)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant