Storage amount not changing after storehouse built

[aymericdelab]

Fixes #2060

Summary by CodeRabbit

• New Features

  • Updated storehouse capacity calculation to return 0 when no storehouses are present.
  • Enhanced error handling in navigation with improved feedback when no position is found.

• Bug Fixes

  • Adjusted tooltip content for storehouse to reflect the new capacity calculation.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2024 10:42am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Nov 8, 2024 10:42am

[mentatbot]

You are out of MentatBot reviews. Your usage will refresh November 11 at 08:00 AM.

[coderabbitai]

Walkthrough

The changes in the TopLeftNavigation.tsx file involve modifications to the storehouse capacity calculation logic and error handling in the goToMapView function. The capacity now returns 0 when no storehouses are present and adds 1 to the quantity of storehouses for total capacity. Additionally, the error handling for position retrieval has been improved, and the tooltip content has been updated to reflect the new capacity logic while retaining the existing population capacity tooltip.

Changes

File Path	Change Summary
client/src/ui/modules/navigation/TopLeftNavigation.tsx	Updated storehouse capacity calculation logic and enhanced error handling in goToMapView. Tooltip content adjusted accordingly.

Assessment against linked issues

Objective	Addressed	Explanation
Storage amount not changing after storehouse built (#2060)	✅

🐰 "In the land where the storehouses grow,
The capacity now adjusts, as we know!
With a hop and a skip, the numbers align,
Errors caught swiftly, all working fine!
So let’s celebrate this change with cheer,
For our storage is ample, let’s give a big cheer!" 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed to generate code suggestions for PR

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

client/src/ui/modules/navigation/TopLeftNavigation.tsx (1)

Line range hint 313-341: Remove commented-out code

These commented-out code blocks should be removed as they're no longer needed and can cause confusion. If this code needs to be referenced later, it can be found in the git history.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 998ad07 and f472fdf.

📒 Files selected for processing (1)

• client/src/ui/modules/navigation/TopLeftNavigation.tsx (1 hunks)

🔇 Additional comments (2)

client/src/ui/modules/navigation/TopLeftNavigation.tsx (2)

154-154: LGTM: Correct handling of no storehouses case

The change to default to 0 when no storehouses exist is correct and necessary for accurate storage capacity calculation.

---

158-159: LGTM: Fixed storage capacity calculation

The new calculation correctly handles both base capacity and additional storehouse capacity:

• Base capacity (300kg) when no storehouses are built
• Properly adds capacity (600kg) when a storehouse is built

This directly addresses the PR objective of fixing the storage amount not updating after storehouse construction.