feat: log transactions that gets no receipt #2048
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
You are out of MentatBot reviews. Your usage will refresh November 11 at 08:00 AM. |
WalkthroughThe changes involve modifications to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Failed to generate code suggestions for PR |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| let receipt; | ||
| try { | ||
| receipt = await this.provider.waitForTransaction(transactionHash, { | ||
| retryInterval: 500, | ||
| }); | ||
| } catch (error) { | ||
| console.error(error); | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance error handling and logging.
The current implementation has several areas for improvement:
- Replace console.error with structured logging that includes the transaction hash for better traceability.
- Preserve error context when re-throwing.
- Emit an event for consistency with other error cases.
Consider applying this improvement:
let receipt;
try {
receipt = await this.provider.waitForTransaction(transactionHash, {
retryInterval: 500,
});
} catch (error) {
- console.error(error);
- throw error;
+ const enhancedError = new Error(`Failed to wait for transaction ${transactionHash}: ${error.message}`);
+ enhancedError.cause = error;
+ this.emit("transactionError", { transactionHash, error: enhancedError });
+ throw enhancedError;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let receipt; | |
| try { | |
| receipt = await this.provider.waitForTransaction(transactionHash, { | |
| retryInterval: 500, | |
| }); | |
| } catch (error) { | |
| console.error(error); | |
| throw error; | |
| } | |
| let receipt; | |
| try { | |
| receipt = await this.provider.waitForTransaction(transactionHash, { | |
| retryInterval: 500, | |
| }); | |
| } catch (error) { | |
| const enhancedError = new Error(`Failed to wait for transaction ${transactionHash}: ${error.message}`); | |
| enhancedError.cause = error; | |
| this.emit("transactionError", { transactionHash, error: enhancedError }); | |
| throw enhancedError; | |
| } |
ponderingdemocritus
deleted the
feat/log-transactionhash-for-no-receipt
branch
Summary by CodeRabbit
New Features
Bug Fixes