Fix/donkey img #1717
Fix/donkey img #1717
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Preparing PR description... |
|
Preparing review... |
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes in this PR appear to address the issues mentioned in the summary (#1710 and #1627). The modifications improve consistency in naming (changing 'Donkeys' to 'Donkey') and add a helpful null check in the ArmyManager. However, there are a few areas that could be further improved:
- The description for the Donkey resource is very brief and could be expanded.
- The image URL for the Donkey resource still points to a wheat image and should be updated.
- It might be beneficial to review the codebase for other opportunities to add null checks or use enums consistently.
Overall, these changes seem to be a step in the right direction, but a bit more attention to detail could make this PR even better.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
| value: 249, | ||
| colour: "#ec4899", | ||
| id: 249, | ||
| description: "Donkeys.", | ||
| description: "Donkey.", | ||
| img: "https://github.com/BibliothecaForAdventurers/voxel-resources/blob/main/compressed/wheat.gif?raw=true", |
There was a problem hiding this comment.
The image URL for the Donkey resource still points to a wheat image. Update this to an appropriate donkey image if one is available.
| img: "https://github.com/BibliothecaForAdventurers/voxel-resources/blob/main/compressed/wheat.gif?raw=true", | |
| img: "https://github.com/BibliothecaForAdventurers/voxel-resources/blob/main/compressed/donkey.gif?raw=true", |
Fixes #1710
Fixes #1627