Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove order icon for player address info #1707

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

bob0005
Copy link
Collaborator

@bob0005 bob0005 commented Sep 23, 2024

Fixes #1705
Fixes #1702

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 4:05pm

Copy link

Preparing PR description...

Copy link

Preparing review...

Copy link
Contributor

@mentatbot mentatbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good overall and successfully remove the Order icon and related functionality from the leaderboards and co-owner lists. The grid layouts have been adjusted accordingly, and unnecessary imports and function calls have been removed. However, there are a few minor adjustments needed to ensure consistency and remove any leftover references to the removed functionality. These adjustments are mostly related to updating grid layouts and removing unused imports. Once these small changes are made, the PR should be ready for merging.

Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!

@edisontim edisontim merged commit ae4a5e7 into main Sep 23, 2024
8 checks passed
@edisontim edisontim deleted the enh/remove-orderIcon branch September 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants