Enh/cleanup (#1151)

* small cleanup

* clean unused bank files

* Move type to type file + rebase

* fix knip

.knip.json

@@ -7,16 +7,10 @@
     "eternum-docs/package.json",
     "eternum-docs/vocs.config.ts",
     "sdk/packages/eternum/global.d.ts",
-
+    "config/bank/index.ts",
     "**/**__test__**/**",
     "**/**__tests__**/**",
 
-    "client/src/dojo/events/bankEventQueries.ts",
-    "client/src/hooks/store/useBankStore.tsx",
-    "client/src/ui/components/bank/BankEntityList.tsx",
-    "client/src/ui/components/bank/BankStats.tsx",
-    "config/bank/index.ts",
-
     "client/src/three/components/FogManager.ts",
     "client/src/hooks/useUISound.tsx"
   ]

client/src/hooks/useUISound.tsx

@@ -2,7 +2,7 @@ import useSound from "use-sound";
 import useUIStore from "./store/useUIStore";
 import { BuildingType, ResourcesIds } from "@bibliothecadao/eternum";
 import { useCallback, useState } from "react";
-import { ResourceMiningTypes } from "@/ui/utils/utils";
+import { ResourceMiningTypes } from "@/types";
 
 const dir = "/sound/";
 

client/src/types/index.ts

@@ -4,3 +4,10 @@ export interface Health {
   current: bigint;
   lifetime: bigint;
 }
+
+export enum ResourceMiningTypes {
+  Forge = "forge",
+  Mine = "mine",
+  LumberMill = "lumber_mill",
+  Dragonhide = "dragonhide",
+}

client/src/ui/components/construction/SelectPreviewBuilding.tsx

@@ -32,10 +32,11 @@ import { ResourceCost } from "@/ui/elements/ResourceCost";
 import { ResourceIcon } from "@/ui/elements/ResourceIcon";
 import { unpackResources } from "@/ui/utils/packedData";
 import { hasEnoughPopulationForBuilding } from "@/ui/utils/realms";
-import { ResourceIdToMiningType, ResourceMiningTypes } from "@/ui/utils/utils";
+import { ResourceIdToMiningType } from "@/ui/utils/utils";
 import { BUILDING_COSTS_SCALED } from "@bibliothecadao/eternum";
 import React, { useMemo, useState } from "react";
 import { HintSection } from "../hints/HintModal";
+import { ResourceMiningTypes } from "@/types";
 
 // TODO: THIS IS TERRIBLE CODE, PLEASE REFACTOR
 

client/src/ui/components/military/TroopChip.tsx

@@ -11,7 +11,7 @@ export const TroopMenuRow = ({
   className?: string;
 }) => {
   return (
-    <div className={`grid w-full grid-cols-3 gap-2 relative w-full text-gold font-bold ${className}`}>
+    <div className={`grid grid-cols-3 gap-2 relative w-full text-gold font-bold ${className}`}>
       <div className="px-2 py-1 bg-gold/10 clip-angled-sm flex flex-col justify-between gap-2 border border-gold/10">
         <ResourceIcon withTooltip={false} resource={"Crossbowman"} size="lg" />
         <div className="text-green text-xs self-center">{currencyFormat(troops?.crossbowman_count || 0, 0)}</div>

client/src/ui/components/structures/construction/StructureConstructionMenu.tsx

@@ -1,26 +1,17 @@
 import useUIStore from "@/hooks/store/useUIStore";
 import {
-  BUILDING_CAPACITY,
-  BUILDING_POPULATION,
-  BuildingType,
   EternumGlobalConfig,
   HYPERSTRUCTURE_POINTS_PER_CYCLE,
   ID,
-  RESOURCE_INFORMATION,
-  RESOURCE_INPUTS_SCALED,
   STRUCTURE_COSTS_SCALED,
   StructureType,
-  findResourceById,
 } from "@bibliothecadao/eternum";
-
 import { getResourceBalance } from "@/hooks/helpers/useResources";
 import { useQuestStore } from "@/hooks/store/useQuestStore";
 import useRealmStore from "@/hooks/store/useRealmStore";
 import { QuestId } from "@/ui/components/quest/questDetails";
 import { Headline } from "@/ui/elements/Headline";
 import { ResourceCost } from "@/ui/elements/ResourceCost";
-import { ResourceIcon } from "@/ui/elements/ResourceIcon";
-import { BUILDING_COSTS_SCALED } from "@bibliothecadao/eternum";
 import clsx from "clsx";
 import React from "react";
 import { StructureCard } from "./StructureCard";

client/src/ui/config.tsx

@@ -1,14 +1,8 @@
+import { ResourceMiningTypes } from "@/types";
 import { BuildingType } from "@bibliothecadao/eternum";
 
 export const FELT_CENTER = 2147483647;
 
-enum ResourceMiningTypes {
-  Forge = "forge",
-  Mine = "mine",
-  LumberMill = "lumber_mill",
-  Dragonhide = "dragonhide",
-}
-
 const BUILD_IMAGES_PREFIX = "/images/buildings/construction/";
 export const BUILDING_IMAGES_PATH = {
   [BuildingType.Castle]: "",

client/src/ui/modules/military/battle-view/BattleDetails.tsx

@@ -6,7 +6,7 @@ export const BattleDetails = ({ armies }: { armies: (ArmyInfo | undefined)[] | u
   const { getAddressName } = useRealm();
   return (
     <div className="w-full">
-      <div className="p-2 w-full grid grid-cols-2 text-gold border-gold/20 border-gradient clip-angled p-2">
+      <div className="w-full grid grid-cols-2 text-gold border-gold/20 border-gradient clip-angled p-2">
         <div key={0} className="mb-4 tile h-6 text-left border border-gold/20">
           Army
         </div>

client/src/ui/utils/utils.tsx

@@ -18,6 +18,7 @@ import { FELT_CENTER } from "../config";
 import { SortInterface } from "../elements/SortButton";
 import * as THREE from "three";
 import { HEX_HORIZONTAL_SPACING, HEX_VERTICAL_SPACING } from "@/three/scenes/HexagonScene";
+import { ResourceMiningTypes } from "@/types";
 
 export { getEntityIdFromKeys };
 
@@ -170,13 +171,6 @@ export const pseudoRandom = (x: number, y: number) => {
   return n - Math.floor(n);
 };
 
-export enum ResourceMiningTypes {
-  Forge = "forge",
-  Mine = "mine",
-  LumberMill = "lumber_mill",
-  Dragonhide = "dragonhide",
-}
-
 export const ResourceIdToMiningType: Partial<Record<ResourcesIds, ResourceMiningTypes>> = {
   [ResourcesIds.Copper]: ResourceMiningTypes.Forge,
   [ResourcesIds.ColdIron]: ResourceMiningTypes.Forge,