Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: fix mismatched argument type #220

Merged
merged 1 commit into from
Sep 12, 2024
Merged

examples: fix mismatched argument type #220

merged 1 commit into from
Sep 12, 2024

Conversation

bhbs
Copy link
Contributor

@bhbs bhbs commented Sep 12, 2024 •
edited
Loading

Fixes #219

Description

createBidirectionalStream returns not WebTransportReceiveStream but WebTransportBidirectionalStream.

So, We have to pass .readable

ref: https://developer.mozilla.org/en-US/docs/Web/API/WebTransportBidirectionalStream
ref: w3c/webtransport/samples/echo/client.js#72

Test

cargo run --example full
  1. Click Connect
  2. Select Open a bidirectional stream
  3. Click Send data -> Receive ACK

@bhbs bhbs marked this pull request as ready for review September 12, 2024 14:40
@BiagioFesta
Copy link
Owner

Thank you for the feedback and the fix :)

@BiagioFesta BiagioFesta merged commit 294e015 into BiagioFesta:master Sep 12, 2024
8 checks passed
@bhbs bhbs deleted the fix-219 branch September 12, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiagioFesta BiagioFesta BiagioFesta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when executing example to open a bidirectional stream
2 participants
@bhbs @BiagioFesta