Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to [email protected] (patched). #210

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

finnbear
Copy link
Contributor

@finnbear finnbear commented Sep 2, 2024

Update to a version of quinn that enforces a version of quinn-proto that is patched against CVE-2024-45311.

@BiagioFesta
Copy link
Owner

BiagioFesta commented Sep 2, 2024

This library (which is the general recommended way in rust) does not publish Cargo.lock.

This means the consumers of wtransport will get whatever quinn/quinn-proto (as all other deps) version is semver compatible.

In particular, from Cargo.toml, consumers of wtransport are going to use any quinn 0.11.x versions.

Nevertheless, I want to keep this CR and update the manifest (Cargo.toml) for maintenance purpose and keep it aligned with the current "live" versions if possible

As always, thank you for work on quinn and this library! :)

@finnbear
Copy link
Contributor Author

finnbear commented Sep 2, 2024

This means the consumers of wtransport will get whatever quinn/quinn-proto (as all other deps) version is semver compatible.

See discussion here for why, while that is mostly true, is isn't always true.

@finnbear finnbear marked this pull request as ready for review September 3, 2024 16:31
@finnbear finnbear changed the title Update to a patched version of quinn deps: update to [email protected] (patched). Sep 3, 2024
@finnbear finnbear changed the title deps: update to [email protected] (patched). deps: update to [email protected] (patched). Sep 3, 2024
@BiagioFesta BiagioFesta merged commit 6740367 into BiagioFesta:master Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants