Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Ugit Bash File - Replaced HEREDOC #70

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

T-Joseph-Kim
Copy link
Contributor

@T-Joseph-Kim T-Joseph-Kim commented Feb 2, 2024

Removed usage of HEREDOC and replaced with preferred "printf" statements for printing "--help" text in the Ugit bash file.
Fixes Issue #67

Initial status of --help text with reliance on "cat" command:

image

Current status of --help text replaced with "printf" statements:

image

Result:

image

With this change, the following would be achieved:

  • Readability: each line of the help text is formatted individually, making it easier to understand.
  • Ease of modification: using individual "printf" commands allows for easier modification of those lines without affecting the entire block fo text.
  • Consistency: the overall script uses printf in other parts, replacing HEREDOC with printf ensures consistency.
  • Avoiding External Commands: eliminates the reliance on the cat command, making the script more self-contained.

Removed usage of HEREDOCS and replaced with preferred "printf" statements for printing "--help" text.
Copy link
Owner

@Bhupesh-V Bhupesh-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey everything looks great, Just a couple of grammar fixes

ugit Outdated Show resolved Hide resolved
ugit Outdated Show resolved Hide resolved
ugit Outdated Show resolved Hide resolved
T-Joseph-Kim and others added 3 commits February 2, 2024 12:30
Co-authored-by: Bhupesh Varshney <[email protected]>
Co-authored-by: Bhupesh Varshney <[email protected]>
Co-authored-by: Bhupesh Varshney <[email protected]>
@Bhupesh-V Bhupesh-V merged commit d76d376 into Bhupesh-V:master Feb 2, 2024
1 check passed
@T-Joseph-Kim
Copy link
Contributor Author

Ah thank you for the grammar fixes, I have committed your suggestions. Thank you for the help and allowing me to contribute!

@Bhupesh-V Bhupesh-V requested review from Bhupesh-V and removed request for Bhupesh-V February 2, 2024 17:35
@Bhupesh-V
Copy link
Owner

@all-contributors please add @T-Joseph-Kim for code

Copy link
Contributor

@Bhupesh-V

I've put up a pull request to add @T-Joseph-Kim! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants