Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running ugit inside docker #68

Closed
4 tasks done
Bhupesh-V opened this issue Jan 31, 2024 · 0 comments
Closed
4 tasks done

Add support for running ugit inside docker #68

Bhupesh-V opened this issue Jan 31, 2024 · 0 comments

Comments

@Bhupesh-V
Copy link
Owner

Bhupesh-V commented Jan 31, 2024

Is your feature request related to a problem? Please describe.

We are planning to ship a docker image for ugit, which everyone would be able to pull from dockerhub registry. We need to make few adjustments in ugit for that.

Describe the solution you'd like

To aid this, we will introduce a new boolean ENV variable UGIT_RUNNING_IN_DOCKER. Use this new variabel to perform following things:

  • Don't open the guide when user invokes the script with --guide flag. Instead, just display the URL of the guide.
  • Don't update the script when user invokes the script using --update flag, just print what version of script a user is using, and tell them to pull the latest image.

Other items that are related to this:

Describe alternatives you've considered

No response

@Bhupesh-V Bhupesh-V pinned this issue Jan 31, 2024
@Bhupesh-V Bhupesh-V self-assigned this Feb 2, 2024
Bhupesh-V added a commit that referenced this issue Feb 2, 2024
- dont update ugit inside docker
- instead of opening browser print the guide url
Bhupesh-V added a commit that referenced this issue Feb 2, 2024
- don't update ugit inside docker
- instead of opening a browser, print the guide URL
- remove usage of basename on help text (#66)
@Bhupesh-V Bhupesh-V unpinned this issue Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant