Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort tags in proper order in "Undo git tag" #64

Closed
wrecklass opened this issue Oct 15, 2023 · 2 comments · Fixed by #65
Closed

Sort tags in proper order in "Undo git tag" #64

wrecklass opened this issue Oct 15, 2023 · 2 comments · Fixed by #65
Labels
beginner good first issue Good for newcomers hacktoberfest priority: medium up for grabs

Comments

@wrecklass
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The current ugit method to undo_git_tag() calls git tag. This presents the tags in a string sort order that looks incorrectly sorted with numeric tags. For instance:

v1.0
v1.1
v1.10
v1.11
v1.2
v1.3
v1.4

etc.

Describe the solution you'd like

Use git tag --sort=v:refname to present tags in correct order:

v1.0
v1.2
v1.3
v1.4
v1.10
v1.11

etc.

Describe alternatives you've considered

You could create your own sorting method, but why?
@Bhupesh-V
Copy link
Owner

@wrecklass that's a nice find, thanks for reporting
LMK if you want to take this up

@wrecklass
Copy link
Contributor Author

Sure, I can do a PR.

wrecklass added a commit to wrecklass/ugit that referenced this issue Oct 19, 2023
@wrecklass
Sort tags by refname in fzf list. Issue Bhupesh-V#64
40289fd
Bhupesh-V added a commit that referenced this issue Oct 20, 2023
@Bhupesh-V
Merge pull request #65 from wrecklass/master
1f4a0c5 
Sort tags by refname in fzf list. Issue #64
@Bhupesh-V Bhupesh-V linked a pull request Oct 20, 2023 that will close this issue
Sort tags by refname in fzf list. Issue #64 #65
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner good first issue Good for newcomers hacktoberfest priority: medium up for grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort tags by refname in fzf list. Issue #64 wrecklass/ugit
2 participants
@wrecklass @Bhupesh-V