Merged
Conversation
Irving-Betterment
force-pushed
the
icaro/rails_7_2_upgrade
branch
from
6db1f65 to
5ffb90a
Compare
Irving-Betterment
force-pushed
the
icaro/rails_7_2_upgrade
branch
from
5ffb90a to
e5d07d6
Compare
Fixing `DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will be removed in Rails 8.0.`
|
|
||
| # Avoid deprecation notices by pinning mail to Ruby 2.7.5 compatible version | ||
| gem 'mail', '~> 2.7.1' | ||
| gem 'mail' |
Contributor
Author
There was a problem hiding this comment.
Unpinning this gem now that it does not longer support Ruby 2.7.5, allowing to bump up to a version supporting Rails 7.2+.
Contributor
Author
There was a problem hiding this comment.
The app doesn't call secrets explicitly itself; and I am promoting a monkey patch to appease the deprecation coming from devise.
Fix "DEPRECATION WARNING: `rails/console/helpers` has been deprecated and will be removed in Rails 8.0."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request bumps the application to Rails 7.2; it also updates its dependencies, addressing Rails 8.0 related deprecation warnings.
Other Information
I introduced a well-known patch to appease
devisereporting Rails related deprecation warnings, until the fix is released by the gem./domain @Betterment/test_track_core