Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debug messages #172

Merged
merged 2 commits into from
Sep 14, 2024
Merged

add debug messages #172

merged 2 commits into from
Sep 14, 2024

Conversation

ar-cyber
Copy link
Contributor

No description provided.

SethBurkart123

This comment was marked as outdated.

Sign in to view

SethBurkart123
SethBurkart123 requested changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@SethBurkart123 SethBurkart123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the console.log to a console.debug so that the messages can be easily toggled.

@ar-cyber
Copy link
Contributor Author

ok

@ar-cyber
Copy link
Contributor Author

Change the console.log to a console.debug so that the messages can be easily toggled.

console.debug outputs nothing

@ar-cyber
Copy link
Contributor Author

ar-cyber commented Sep 13, 2024 •
edited
Loading

updated all to make them use console.info, which is much better for debug messages

@Crazypersonalph Crazypersonalph marked this pull request as ready for review September 13, 2024 13:19
Crazypersonalph
Crazypersonalph approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Crazypersonalph Crazypersonalph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also maybe check in other files and functions whether they use logging.

@ar-cyber
Copy link
Contributor Author

ok

@Crazypersonalph
Copy link
Collaborator

Change the console.log to a console.debug so that the messages can be easily toggled.

console.debug outputs nothing

You need to change log level in DevTools.

@ar-cyber
Copy link
Contributor Author

Change the console.log to a console.debug so that the messages can be easily toggled.

console.debug outputs nothing

You need to change log level in DevTools.

ah. I'll still use console.info because it looks nicer in DevTools

@SethBurkart123 SethBurkart123 merged commit f9c3fbc into BetterSEQTA:main Sep 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crazypersonalph Crazypersonalph Crazypersonalph approved these changes

@SethBurkart123 SethBurkart123 SethBurkart123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ar-cyber @Crazypersonalph @SethBurkart123