Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change middleware to support rails app in subfolders #103

Merged
merged 1 commit into from
Mar 9, 2013
Merged

Change middleware to support rails app in subfolders #103

merged 1 commit into from
Mar 9, 2013

Conversation

thomet
Copy link
Contributor

@thomet thomet commented Jan 28, 2013

If two applications run on the same domain

first_rails_app -> in http:://any_domain/
second_rails_app -> in http://any_domain/seccond_application

and in the second one a error is occured then "__better_errors" from the second app should be called.

To provide this the regular expression for the better_errors_call-Method should listen on any "__better_errors" string on any page.

@ghost
Copy link

ghost commented Jan 30, 2013

It's a super simple fix, but it solves the problem flawlessly. Moreover, test spec is included.
@thomet: thanks for your attention to the problem!

@qqshfox
Copy link
Contributor

qqshfox commented Feb 11, 2013

It works. Thanks for @thomet.

@grncdr
Copy link

grncdr commented Feb 21, 2013

I can confirm that this fixes #93 for me

@ur5us
Copy link

ur5us commented Feb 28, 2013

👍

@SeriousM
Copy link

SeriousM commented Mar 1, 2013

I had a problem with rails_admin mounted under /admin.
better_errors was failing requesting http://localhost:3000/admin/__better_errors/123456/variables/...
therefor there was no error information about.
with this pull request the error is visible again!

image

thanks for that 👍

@ramigg
Copy link

ramigg commented Mar 5, 2013

👍
This pull request fixed the same issue I had with mountable engines I use.

Please merge it

@ghost
Copy link

ghost commented Mar 8, 2013

@charliesome, any updates on this pull request?
There're at least 9 people waiting this fix.
Engines are the official way of some sort of DRY and wouldn't be removed in rails 4.
In addition to that, there're some popular gems which related on engines (for example, active_admin).
Could you comment on the weak points which you see of this solution so someone could improve it to merge to upstream?

@deiga
Copy link

deiga commented Mar 8, 2013

👍

haileys pushed a commit that referenced this pull request Mar 9, 2013
…s_app_in_subfolders

Change middleware to support rails app in subfolders
@haileys haileys merged commit d2b0ffc into BetterErrors:master Mar 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants