SeriesBuilder missing generics parameter appreciated#185

Bethibande · Jul 12, 2024 · b3fd2a7 · b3fd2a7
1 parent 1758aca
commit b3fd2a7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/com/github/appreciated/apexcharts/config/builder/SeriesBuilder.java b/src/main/java/com/github/appreciated/apexcharts/config/builder/SeriesBuilder.java
@@ -11,8 +11,8 @@ public class SeriesBuilder<T> {
     private SeriesBuilder() {
     }
 
-    public static SeriesBuilder<?> get() {
-        return new SeriesBuilder();
+    public static <T> SeriesBuilder<T> get() {
+        return new SeriesBuilder<>();
     }
 
     public SeriesBuilder<T> withName(String name) {

diff --git a/src/test/java/com/github/appreciated/apexcharts/examples/line/LineChartExample.java b/src/test/java/com/github/appreciated/apexcharts/examples/line/LineChartExample.java
@@ -29,6 +29,9 @@ public LineChartExample() {
                         .withCategories("Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep")
                         .withTickPlacement(TickPlacement.BETWEEN)
                         .build())
-                .withSeries(new Series<>("Desktops", 10.0, 41.0, 35.0, 51.0, 49.0, 62.0, 69.0, 91.0, 148.0));
+                .withSeries(SeriesBuilder.get()
+                                    .withName("Desktops")
+                                    .withData(10.0, 41.0, 35.0, 51.0, 49.0, 62.0, 69.0, 91.0, 148.0)
+                                    .build());
     }
 }