Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Form Error Translations #1504

Closed
1 task done
migbash opened this issue Aug 8, 2023 · 2 comments
Closed
1 task done

[FEATURE]: Form Error Translations #1504

migbash opened this issue Aug 8, 2023 · 2 comments
Assignees
@migbash
Labels
🌟 [A] enhancement New feature or request 🎨 Frontend

Comments

@migbash
Copy link
Collaborator

migbash commented Aug 8, 2023

Does a duplicate issue exist?

  • I have searched the existing issues

🤔 Is feature request related to a problem? Please describe the problem.

  • All data from the betarena_general_data/translations/withdraw_forms > form_errors appears to be missing.

📝 Feature Request Description

Need to update the data on the betarena_general_data/translations/withdraw_forms > form_errors to correctly show the error messages in different supported languages.

For guidance purposes, currently, the following translations are being used as hardcoded values on dev:

  • Value must be a valid integer
  • You don't have an sufficient balance
  • You only have $X available in your balance
  • A minimum of 5 BTA is required to withdraw
  • Invalid email
  • Invalid BIC/SWIFT input
  • Invalid IBAN input

Important
Please use capital letters, such as: X, Y as given in examples above, to signal a dynamic value that will be switched at runtime.

Important
Please use the following new added structure to form_errors data column of lang: EN. A copy of the expected data structure is given below.

form_errors (column)

{
  "lang":"en",
  "wrong_format":"Wrong Format",
  "<new_error_key>": "<new_error_message>"
}

➕ Further context and resources (cummulative)

No response
@migbash migbash added 🌟 [A] enhancement New feature or request 🎨 Frontend labels Aug 8, 2023
@migbash migbash moved this to Todo in Betarena Scores Aug 8, 2023
@jonsnowpt jonsnowpt moved this from Todo to In Progress in Betarena Scores Aug 8, 2023
@jonsnowpt
Copy link
Contributor

@migbash

Added to all languages:

{
  "lang": "en",
  "wrong_format": "Wrong Format",
  "value_integer": "Value must be a valid integer",
  "no_balance": "You don't have an sufficient balance",
  "enough_balance": "You only have $X available in your balance",
  "min_balance": "A minimum of 5 BTA is required to withdraw",
  "invalid_email": "Invalid email",
  "invalid_bic": "Invalid BIC/SWIFT input",
  "invalid_iban": "Invalid IBAN input"
}

@jonsnowpt jonsnowpt moved this from In Progress to Todo in Betarena Scores Aug 8, 2023
@jonsnowpt jonsnowpt assigned migbash and unassigned jonsnowpt Aug 8, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Aug 8, 2023
@migbash migbash moved this from In Progress to Staging in Betarena Scores Aug 8, 2023
migbash added a commit that referenced this issue Aug 8, 2023
@migbash
issue: #1504;
5e69e09
@migbash migbash moved this from Staging to Testing in Betarena Scores Aug 8, 2023
@migbash
Copy link
Collaborator Author

migbash commented Aug 8, 2023

Note
Active on DEV since v793.

@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Aug 8, 2023
migbash added a commit that referenced this issue Aug 9, 2023
@migbash
Feature/1421/user-profile-withdraw (#1479)
175e627 
* feat: #1421; new Withdraw Widget-Main + Modal;

* feat: #1421; new Withdraw assets;

* feat: #1421; new Withdraw Widget ref +page.svelte;

* chore: clean store/user-settings.ts;

* doc: OpenApi adjust for Tx to DB action endpoint;

* feat: #1421; new balance Firebase upd func; clean;

* feat: #1421; endpoint /api/data/profile POST add;

* update: app.css for global form > input; clean;

* feat: #1421; add Withdraw-Widget Profile/Menu-Opt;

* feat: #1421; endpoint /api/data/profile; cont;

* pkg: @scores-lib ➤ 1.4.0;

* issue: #1483;

* pkg: ibantools 4.3.3;

* pkg: @scores-lib ➤ 1.4.1;

* issue: #1483; withdraw-fixes; cont;

* issue: #1486;

* issue: #1485;

* issue: #1486; cont;

* issue: #1488;

* issue: #1491;

* issue: #1497; #1489; #1495;

* issue: #1497; cont;

* issue: #1504;

* issue: #1506;

* issue: #1507; #1502;

* issue: #1508;

* issue: #1497;

* issue: #1497; cont;

* issue: #1497; cont;

* pkg: @scores-lib ➤ 1.4.4;

* issue: #1491;

* pkg: @scores-lib ➤ 1.4.5;

* issue: #1491; adjust show more action text;

* issue: #1498;

* pkg: @scores-lib ➤ 1.4.6;

* issue: #1498; types update;

* chore: firebase secrets;

* chore: firebase secrets;
jonsnowpt pushed a commit that referenced this issue Aug 10, 2023
@migbash
major (#1511)
1171eef 
* chore: add vscode/snippets.code-snippets;

* chore: Footer re-structure;

* chore: app.css comments + clean;

* update: +layout Footer re-structure;

* chore: components/home/leagues-list -> v6;

* chore: components/home/leagues-table -> v6;

* chore: components/home/seo-block -> v6;

* upd: +layout league-list; league-table; seo-block;

* update: vscode/snippets.code-snippets;

* update: Makefile;

* update: Makefile;

* update: package.json > scripts;

* update: package.json > scripts;

* update: package.json;

* update: vscode/snippets.code-snippets;

* Feature/1421/user-profile-withdraw (#1479)

* feat: #1421; new Withdraw Widget-Main + Modal;

* feat: #1421; new Withdraw assets;

* feat: #1421; new Withdraw Widget ref +page.svelte;

* chore: clean store/user-settings.ts;

* doc: OpenApi adjust for Tx to DB action endpoint;

* feat: #1421; new balance Firebase upd func; clean;

* feat: #1421; endpoint /api/data/profile POST add;

* update: app.css for global form > input; clean;

* feat: #1421; add Withdraw-Widget Profile/Menu-Opt;

* feat: #1421; endpoint /api/data/profile; cont;

* pkg: @scores-lib ➤ 1.4.0;

* issue: #1483;

* pkg: ibantools 4.3.3;

* pkg: @scores-lib ➤ 1.4.1;

* issue: #1483; withdraw-fixes; cont;

* issue: #1486;

* issue: #1485;

* issue: #1486; cont;

* issue: #1488;

* issue: #1491;

* issue: #1497; #1489; #1495;

* issue: #1497; cont;

* issue: #1504;

* issue: #1506;

* issue: #1507; #1502;

* issue: #1508;

* issue: #1497;

* issue: #1497; cont;

* issue: #1497; cont;

* pkg: @scores-lib ➤ 1.4.4;

* issue: #1491;

* pkg: @scores-lib ➤ 1.4.5;

* issue: #1491; adjust show more action text;

* issue: #1498;

* pkg: @scores-lib ➤ 1.4.6;

* issue: #1498; types update;

* chore: firebase secrets;

* chore: firebase secrets;

* Issue/1278/pre load css js (#1510)

* issue: #1278

* issue: #1278; cont;

* issue: #1278; cont;

* issue: #1278; cont;

* issue: #1278; cont;

* issue: #1278; cont;

* issue: #1278; cont;

* issue: #1278; cont; dynamic svg import;

* issue: #1278; cont; dynamic home-page comp import;

* issue: #1278; cont; dynamic home-page comp import;

* chore: Makefile; package.json; update;

* doc: vite.config.ts;

* issue: #1478; Test Header; logic; mobile-first;

* issue: #1478; Test CSS-Js variable communication;

* issue: #1478; vite.config.ts update;

* update: #1478; all-css-chunk.css;

* Revert to e92886 -> home/Layout.svelte;

* update: #1478; all-css-chunk.css;

* update: #1278; empty preloadStrategy;

* update: #1278; preloadStrategy -> preload-js;

* update: #1278; preloadStrategy -> preload-js;

* upd: #1278; preloadStrategy -> preload-js; cont;

* upd: #1278; preloadStrategy -> preload-mjs; cont;

* upd: #1278; build::manualChunks homepage single;

* upd: #1278; build::manualChunks cont;

* upd: #1278; preloadStrategy -> modulepreload;

* upd: #1278; build::manualChunks cont; cssJsChunk;

* upd: #1278; build::manualChunks cont;

* upd: #1278; src/app.html hardcode all CSS;

* revert to ab873 -> vite.config.ts;

* doc: svelte.config.js; vite.config.js;

* update: +layout.server.ts revamp;

* update: +layout.svelte revamp;

* del: +layout.ts in favour of .server.ts;

* doc: [[lang=lang]]/+page.ts;

* chore: remove firebase/common.ts;

* feat: sessionStore add deviceType;

* chore: app.html clean;

* chore: utils/debug.ts clean;

* chore: utils/dates.ts clean;

* chore: utils/platform-functions.ts clean;

* chore: utils/languages.ts clean;

* chore: api/utils.ts clean;

* chore: u/[view]/[lang=lang] page.server.ts;

* update: all homepage widgets entry .svelte;

* update: homepage main Layout.svelte;

* chore: update debug logs on few components;

* issue: #1478; vite.config.ts update;

* update: src/hooks.server.ts;

* update: Auth_Widget.svelte;

* pkg: ua-parser-js; mansory-layout; device-dete-js;

* chore: svelte.config.ts;

* issue: #1478; vite.config.ts update; compression;

* update: +layout.svelte add SplashScreen;

* update: Makefile;

* update: +layout.svelte revert SplashScreen;

* update: +layout.server.ts add setHeaders(..);

* update: svelte.config.ts; add pre-compress;

* update: Makefile;

* update: Makefile;

* issue: #1478; vite.config.ts update; minfication;

* issue: #1478; homepage widgets (some) dynamicload;

* issue: #1478; homepage widgets (cont) dynamicload;

* issue: #1478; single-chunk and in-head css;

* chore: add analytics to app.html;

* doc: svelte.config.ts;

* issue: #1278; adjusting dynamic importing v6.5

* issue: #1278; home/Layout.svelte dynamic v6.5;

* chore: Email-Sub; Offline-Alert; Plat-Alert v6.5;

* chore: Makefile update;

* chore: package.json update;

* chore: translation.ts ;

* chore: +layout.svelte v6.5;

* chore: [[lang=lang]]/+page.svelte v6.5;

* chore: [[lang=lang]]/+page.ts v6.5;

* chore: fix merge errors;

* fix: adjust hardcoded CSS;

* (empty commit);

* fix: adjust vite.config.ts;

* chore: firebase secrets;

* github: workflow secrets;

* github: workflow secrets;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@migbash migbash

Labels
🌟 [A] enhancement New feature or request 🎨 Frontend
Projects
Betarena Scores
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@migbash @jonsnowpt