Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: add missing filters for type and UID #1429

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 10, 2025

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 3fdcfb2
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/6780d2cf8d05a200080a47ba

Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (32cb98a) to head (3fdcfb2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/dns/api_records.go 30.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
- Coverage   60.72%   60.34%   -0.39%     
==========================================
  Files         137      137              
  Lines        7686     7693       +7     
==========================================
- Hits         4667     4642      -25     
- Misses       2571     2600      +29     
- Partials      448      451       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 3f9f244 into main Jan 10, 2025
13 of 15 checks passed
@BeryJu BeryJu deleted the api/dns-more-filtering branch January 10, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant