-
-
Notifications
You must be signed in to change notification settings - Fork 16
dns: fix CNAME answer, mixed-case queries and more #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
BeryJu
commented
Jan 4, 2025
•
edited
Loading
edited
- Improved DNS Testing helpers (already helped find some bugs)
- Fix CNAME records not being added to answer when not explicitly querying CNAME
- Fixed mixed-case queries not returning in the case saved in etcd
- Fixed CNAME recursion limit not applying correctly
- Fix other misc things
✅ Deploy Preview for beryju-gravity canceled.
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
- Coverage 60.05% 59.86% -0.20%
==========================================
Files 137 137
Lines 7641 7654 +13
==========================================
- Hits 4589 4582 -7
- Misses 2605 2626 +21
+ Partials 447 446 -1 ☔ View full report in Codecov by Sentry. |
6423305
to
6f15cba
Compare
6f15cba
to
70e2fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.