Skip to content

dns: fix CNAME answer, mixed-case queries and more #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 5, 2025
Merged

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 4, 2025

  • Improved DNS Testing helpers (already helped find some bugs)
  • Fix CNAME records not being added to answer when not explicitly querying CNAME
  • Fixed mixed-case queries not returning in the case saved in etcd
  • Fixed CNAME recursion limit not applying correctly
  • Fix other misc things

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit b0407b9
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/677a109851012a000866e892

Copy link

codecov bot commented Jan 4, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.86%. Comparing base (12c962a) to head (b0407b9).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/dns/zone_watch.go 0.00% 1 Missing and 1 partial ⚠️
pkg/roles/dns/dns_handler.go 0.00% 1 Missing ⚠️
pkg/roles/dns/role.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   60.05%   59.86%   -0.20%     
==========================================
  Files         137      137              
  Lines        7641     7654      +13     
==========================================
- Hits         4589     4582       -7     
- Misses       2605     2626      +21     
+ Partials      447      446       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the dns/fix-cname-again branch 3 times, most recently from 6423305 to 6f15cba Compare January 5, 2025 04:07
@BeryJu BeryJu force-pushed the dns/fix-cname-again branch from 6f15cba to 70e2fa1 Compare January 5, 2025 04:23
@BeryJu BeryJu changed the title dns: improve testing harness & CNAME stuff again dns: fix CNAME answer, mixed-case queries and more Jan 5, 2025
@BeryJu BeryJu merged commit 0d5052a into main Jan 5, 2025
17 of 18 checks passed
@BeryJu BeryJu deleted the dns/fix-cname-again branch January 5, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant