Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: fix cname cross zone #1306

Merged
merged 7 commits into from
Nov 22, 2024
Merged

DNS: fix cname cross zone #1306

merged 7 commits into from
Nov 22, 2024

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Nov 21, 2024

Fix CNAME lookups across zones...thanks @tigattack

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 9e77c06
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/673fcc39084dbf000889833d

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Project coverage is 21.83%. Comparing base (0e1d858) to head (9e77c06).
Report is 1 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
pkg/roles/dns/dns_handler.go 47.05% 8 Missing and 1 partial ⚠️
pkg/roles/dns/handler_etcd.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   21.72%   21.83%   +0.11%     
==========================================
  Files         232      232              
  Lines       19836    19861      +25     
==========================================
+ Hits         4309     4337      +28     
+ Misses      15075    15073       -2     
+ Partials      452      451       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 1a4c37b into main Nov 22, 2024
10 checks passed
@BeryJu BeryJu deleted the dns/fix-cname-cross-zone branch November 22, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant