Skip to content

Fix wrong URL for internal user invitation - #7762

Merged
2 commits merged into
BerriAI:mainfrom
yujonglee:fix-internal-invite-wrong-url
Jan 15, 2025
Merged

Fix wrong URL for internal user invitation#7762
2 commits merged into
BerriAI:mainfrom
yujonglee:fix-internal-invite-wrong-url

Conversation

@yujonglee

@yujonglee yujonglee commented Jan 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Title

Fix wrong URL for internal user invitation

Relevant issues

Resolves #7191

Type

🐛 Bug Fix
🧹 Refactoring

Changes

Avoid doing URL manipulation via string. Replace them with new URL().

@vercel

vercel Bot commented Jan 14, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 10:43am

yujonglee
yujonglee commented Jan 14, 2025
View reviewed changes

@yujonglee yujonglee left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should adopt this pattern everywhere so that we can avoid this kind of bug :)

Comment thread ui/litellm-dashboard/src/components/create_user_button.tsx
return;
}

const base = new URL("/", window.location.href);

@yujonglee yujonglee Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This

Comment thread ui/litellm-dashboard/src/components/onboarding_link.tsx
Comment on lines +45 to +47
return new URL("/ui", baseUrl).toString();
}
return `${baseUrl}/ui?invitation_id=${invitationLinkData?.id}`;
return new URL(`/ui?invitation_id=${invitationLinkData?.id}`, baseUrl).toString();

@yujonglee yujonglee Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This

@ghost
ghost merged commit 503b38e into BerriAI:main Jan 15, 2025
@yujonglee
yujonglee deleted the fix-internal-invite-wrong-url branch January 15, 2025 23:22
ghost pushed a commit that referenced this pull request Jan 16, 2025
@rajatvig @Hexoplon
@yujonglee @hughcrt Nikolaiev Dmytro
Add in container structure tests for the nonroot image (#7796)
84f9849 
* feat(helm): add securityContext and pull policy values to migration job (#7652)

* fix(helm): corrected indentation in migration-job.yaml

* feat(helm): add securityContext and pull policy values to migration job

* fix confusing save button label (#7778)

* [integrations/lunary] Improve Lunary documentaiton (#7770)

* update lunary doc

* better title

* tweaks

* Update langchain.md

* Update lunary_integration.md

* Fix wrong URL for internal user invitation (#7762)

* format

* done

* Update instructor tutorial (#7784)

* Add in container structure tests for the nonroot image

---------

Co-authored-by: Zackeus Bengtsson <32719220+Hexoplon@users.noreply.github.com>
Co-authored-by: yujonglee <yujonglee.dev@gmail.com>
Co-authored-by: Hugues Chocart <chocart.hugues@icloud.com>
Co-authored-by: Nikolaiev Dmytro <dima.nikol.99@gmail.com>
ghost pushed a commit that referenced this pull request Jan 16, 2025
Krish Dholakia @rajatvig
@Hexoplon @yujonglee @hughcrt Nikolaiev Dmytro
Add back in non root image fixes (#7781) (#7795)
d4ed985 
* Add back in non root image fixes (#7781)

* Add back in non root image fixes

* Fix dockerfile

* Fix perms

* Add in container structure tests for the nonroot image (#7796)

* feat(helm): add securityContext and pull policy values to migration job (#7652)

* fix(helm): corrected indentation in migration-job.yaml

* feat(helm): add securityContext and pull policy values to migration job

* fix confusing save button label (#7778)

* [integrations/lunary] Improve Lunary documentaiton (#7770)

* update lunary doc

* better title

* tweaks

* Update langchain.md

* Update lunary_integration.md

* Fix wrong URL for internal user invitation (#7762)

* format

* done

* Update instructor tutorial (#7784)

* Add in container structure tests for the nonroot image

---------

Co-authored-by: Zackeus Bengtsson <32719220+Hexoplon@users.noreply.github.com>
Co-authored-by: yujonglee <yujonglee.dev@gmail.com>
Co-authored-by: Hugues Chocart <chocart.hugues@icloud.com>
Co-authored-by: Nikolaiev Dmytro <dima.nikol.99@gmail.com>

---------

Co-authored-by: Rajat Vig <rajatvig@users.noreply.github.com>
Co-authored-by: Zackeus Bengtsson <32719220+Hexoplon@users.noreply.github.com>
Co-authored-by: yujonglee <yujonglee.dev@gmail.com>
Co-authored-by: Hugues Chocart <chocart.hugues@icloud.com>
Co-authored-by: Nikolaiev Dmytro <dima.nikol.99@gmail.com>
@yujonglee yujonglee mentioned this pull request Jan 18, 2025
Closed
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
@yujonglee
Fix wrong URL for internal user invitation (BerriAI#7762)
dfe84d6 
* format

* done
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
Krish Dholakia @rajatvig
@Hexoplon @yujonglee @hughcrt Nikolaiev Dmytro
Add back in non root image fixes (BerriAI#7781) (BerriAI#7795)
b3d85e3 
* Add back in non root image fixes (BerriAI#7781)

* Add back in non root image fixes

* Fix dockerfile

* Fix perms

* Add in container structure tests for the nonroot image (BerriAI#7796)

* feat(helm): add securityContext and pull policy values to migration job (BerriAI#7652)

* fix(helm): corrected indentation in migration-job.yaml

* feat(helm): add securityContext and pull policy values to migration job

* fix confusing save button label (BerriAI#7778)

* [integrations/lunary] Improve Lunary documentaiton (BerriAI#7770)

* update lunary doc

* better title

* tweaks

* Update langchain.md

* Update lunary_integration.md

* Fix wrong URL for internal user invitation (BerriAI#7762)

* format

* done

* Update instructor tutorial (BerriAI#7784)

* Add in container structure tests for the nonroot image

---------

Co-authored-by: Zackeus Bengtsson <32719220+Hexoplon@users.noreply.github.com>
Co-authored-by: yujonglee <yujonglee.dev@gmail.com>
Co-authored-by: Hugues Chocart <chocart.hugues@icloud.com>
Co-authored-by: Nikolaiev Dmytro <dima.nikol.99@gmail.com>

---------

Co-authored-by: Rajat Vig <rajatvig@users.noreply.github.com>
Co-authored-by: Zackeus Bengtsson <32719220+Hexoplon@users.noreply.github.com>
Co-authored-by: yujonglee <yujonglee.dev@gmail.com>
Co-authored-by: Hugues Chocart <chocart.hugues@icloud.com>
Co-authored-by: Nikolaiev Dmytro <dima.nikol.99@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: In the Admin UI, the invitation link for the Internal User is missing a "/".

1 participant

@yujonglee