Skip to content

(helm) - bug fix - allow using migrationJob.enabled variable within job - #7639

Merged
ishaan-jaff merged 5 commits into
mainfrom
litellm_helm_improvements_3
Jan 9, 2025
Merged

(helm) - bug fix - allow using migrationJob.enabled variable within job#7639
ishaan-jaff merged 5 commits into
mainfrom
litellm_helm_improvements_3

Conversation

@ishaan-jaff

@ishaan-jaff ishaan-jaff commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

(helm) - bug fix - allow using migrationJob.enabled variable within job

Issues:

  • using migrationJob.enabled did not work on values.yaml
  • changed argocd.argoproj.io/hook-delete-policy BeforeHookCreation because I want the migration job to delete old migration on a new deploy in case the migration needs to make updates
  • Don't hardcode image url in migration job

Relevant issues

Type

🚄 Infrastructure
✅ Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

@vercel

vercel Bot commented Jan 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:54pm

@ishaan-jaff
ishaan-jaff merged commit 7259452 into main Jan 9, 2025
@ishaan-berri
ishaan-berri deleted the litellm_helm_improvements_3 branch March 26, 2026 21:54
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
… job (BerriAI#7639)

* wrap migration job in conditional

* use enabled flag in values.yaml

* run migration job

* argo cd fixes

* fix values in image repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant