Repository navigation
fix(bedrock/chat/invoke_handler.py): Fix provider parsing in bedrock - #6645
Closed
bhushitagarwal-circle wants to merge 1 commit into
Closed
bhushitagarwal-circle wants to merge 1 commit into
bhushitagarwal-circle wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
This was resolved in the recent versions |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Bedrock has updated the naming convention for the new model names being released. Prior convention was to start the model name with provider name (eg. meta, anthropic) followed by model details. Now, they've added region before provider name. This PR updates provider name extraction to be more generic and compatible for old and new naming convention.
Relevant issues
Fixes #6644
Type
🐛 Bug Fix
Changes
Added a list of bedrock model providers (
bedrock_model_providers) tolitellm/llms/bedrock/chat/invoke_handler.py.Introduced a new function
_get_bedrock_providerto determine the provider from a model string.Updated the
process_responsefunction to use_get_bedrock_providerinstead of splitting the model string directly.Updated the
completionfunction to use_get_bedrock_providerinstead of splitting the model string directly.[REQUIRED] Testing - Attach a screenshot of any new tests passing local
If UI changes, send a screenshot/GIF of working UI fixes