Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@krrishdholakia can you please take a look when you got a chance? |
Contributor
Author
|
@ishaan-jaff can you please take a look when you got a chance? |
Contributor
Author
|
@ishaan-jaff can you please take a look when you got a chance? This is blocking us to use the official image. |
ghost
reviewed
Nov 25, 2024
| optional_params=optional_params, | ||
| client=client, | ||
| aembedding=aembedding, | ||
| extra_headers=extra_headers, |
There was a problem hiding this comment.
this is not necessary. extra_headers is already passed via optional_params
|
Hey @ali-arian extra_headers is already supported on embedding - Line 3390 in c73ce95 which is passed in the request here - litellm/litellm/llms/AzureOpenAI/azure.py Line 881 in c73ce95 |
ghost
closed this
This pull request was closed.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding extra-headers to Embedding
This PR fixes the issue with Embedding not passing the
extra-headersfor azure calls.Relevant issues
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locall
If UI changes, send a screenshot/GIF of working UI fixes