Skip to content

test(integration): delete flaky team model TPM concurrency test - #46541

Merged
kerry-berri merged 1 commit into
mainfrom
litellm_delete_flaky_team_model_tpm_test
Oct 14, 2026
Merged

kerry-berri merged 1 commit into
mainfrom
litellm_delete_flaky_team_model_tpm_test

Conversation

@kerry-berri

Copy link
Copy Markdown
Contributor

Summary

Deletes tests/integration/routing/test_team_model_tpm_limit.py, whose only test, test_concurrent_team_model_tpm_requests_reserve_tokens_before_reaching_the_provider, failed intermittently on main (6 of the last 22 CircleCI runs, always (429, 429, 429) instead of (200, 429, 429))

The failure is real limiter behavior, not a test bug. Under a request-scoped Redis batch, _atomic_lua_per_descriptor in litellm/proxy/hooks/parallel_request_limiter_v3.py pipelines the model_per_key and model_per_team Lua calls together, so concurrent requests can each reserve one counter and all get rejected before the refunds land. It reproduced locally 1 time in 50 with pipelining on and 0 in 50 with it off. The fix was put on hold (#46494 closed for now), so this removes the flake from the integration suite until the limiter is revisited

Caveats

  • Nothing else covers concurrent team per-model TPM reservations end to end, so a regression there will not show up in integration CI after this lands

Link to Devin session: https://app.devin.ai/sessions/b692f38aa3154bac8d195178279a7b1c
Open in Devin Desktop: https://app.devin.ai/desktop/session/b692f38aa3154bac8d195178279a7b1c?variant=devin
Requested by: @kerrylu-berri

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor Author

@litellm-stampbot

@litellm-stampbot

Copy link
Copy Markdown

litellm-stampbot: risk low

Approved at 561d881.

Rules (stampbot/risk_rules.yml):

  • low: no rule flagged it

Judge: skipped, the rules alone decided.

Pushes do not re-run this check. Comment @litellm-stampbot again to re-check the new head.

@litellm-stampbot litellm-stampbot Bot added the risk:low Small, isolated, low-risk change label Oct 14, 2026

@litellm-stampbot litellm-stampbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low risk by rule and by judgement at 561d881

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kerry-berri
kerry-berri merged commit 7d7e288 into main Oct 14, 2026
86 checks passed
@kerry-berri
kerry-berri deleted the litellm_delete_flaky_team_model_tpm_test branch October 14, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Small, isolated, low-risk change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants