Repository navigation
test(integration): delete flaky team model TPM concurrency test - #46541
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
|
Contributor
Author
litellm-stampbot: risk lowApproved at Rules (
Judge: skipped, the rules alone decided. Pushes do not re-run this check. Comment |
litellm-stampbot
approved these changes
Oct 14, 2026
litellm-stampbot
left a comment
Contributor
There was a problem hiding this comment.
Low risk by rule and by judgement at 561d881
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
tests/integration/routing/test_team_model_tpm_limit.py, whose only test,test_concurrent_team_model_tpm_requests_reserve_tokens_before_reaching_the_provider, failed intermittently on main (6 of the last 22 CircleCI runs, always(429, 429, 429)instead of(200, 429, 429))The failure is real limiter behavior, not a test bug. Under a request-scoped Redis batch,
_atomic_lua_per_descriptorinlitellm/proxy/hooks/parallel_request_limiter_v3.pypipelines themodel_per_keyandmodel_per_teamLua calls together, so concurrent requests can each reserve one counter and all get rejected before the refunds land. It reproduced locally 1 time in 50 with pipelining on and 0 in 50 with it off. The fix was put on hold (#46494 closed for now), so this removes the flake from the integration suite until the limiter is revisitedCaveats
Link to Devin session: https://app.devin.ai/sessions/b692f38aa3154bac8d195178279a7b1c
Open in Devin Desktop: https://app.devin.ai/desktop/session/b692f38aa3154bac8d195178279a7b1c?variant=devin
Requested by: @kerrylu-berri