Repository navigation
fix(guardrails): restore supported_decisions_providers on stable/1.104.x so Add Guardrail settings load - #45935
Merged
mateo-berri merged 1 commit intoOct 11, 2026
Conversation
…rdrail settings endpoint loads on stable/1.104.x Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
@litereview greptile code-review |
Contributor
|
bugbot run |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7cd5407. Configure here.
Contributor
|
@litereview greptile code-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
GET /guardrails/ui/add_guardrail_settingsreturns 500 with an ImportError on every callHow it solves it:
litellm.decisions.call, where the backport moved itsupported_decisions_providers, matching rc/1.105.0 and mainUser Flow
Before: an admin opening the Add Provider Guardrail wizard on a stable/1.104.x proxy sees an empty provider list
Internal server error, so the wizard has no providers to pickAfter: the same wizard loads its providers
Affected release
Regression on stable/1.104.x since #45906
Pre-Submission checklist
uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Same config on both sides:
model_list: []and a master key from the environment, no database. Before runs the stable/1.104.x tip on port 4101 and After runs this branch on port 4102. The endpoint makes no provider call, so there is no provider spendBefore (0939a83)
curl -s -w '\nHTTP %{http_code}\n' -H "Authorization: Bearer $LITELLM_MASTER_KEY" http://localhost:4101/guardrails/ui/add_guardrail_settingsAfter (7cd5407)
decision_model_providersreadsType
🐛 Bug Fix
Final Attestation
Note
Low Risk
Narrow import-path and symbol rename fix for guardrail UI settings; no changes to auth, billing, or decision API runtime behavior beyond restoring the listing endpoint.
Overview
Fixes a stable/1.104.x regression where
GET /guardrails/ui/add_guardrail_settingsfailed with anImportErrorbecause the proxy still importedsupported_decisions_providersfromlitellm.decisions.mainafter the decisions backport moved that logic.supported_decisions_providersis now defined and exported fromlitellm.decisions.call(renamed from the private_supported_providers), and the guardrail UI endpoint plus its regression test import it from there. The Add Guardrail wizard can loaddecision_model_providersagain instead of returning 500 with an empty provider list.Reviewed by Cursor Bugbot for commit 7cd5407. Bugbot is set up for automated code reviews on this repo. Configure here.