Repository navigation
feat(ui): streamline auto-router setup with deployed decision models - #45913
Conversation
|
@cursor review Please check deployment selection, legacy configuration compatibility, dependency authorization, and the create and edit flows at this tip. |
|
@greptileai Please review the current tip for deployment selection, authorization, legacy compatibility, and create/edit regressions after the test-formatting correction. |
|
@cursor review Please review the updated tip after the test-formatting correction, focusing on deployment selection, permissions, and legacy compatibility. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance
|
|
@greptileai Please review d033e6c, including deployed decision selection, authorization, legacy compatibility, and explicit accounting regression assertions through the real Router path. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d033e6c. Configure here.
Current verification status
Independent source verification passed on this final commit, including create, reopen, change deployment, invoke, legacy compatibility, and nonzero cost/provider recording in spend logs. No concrete defects were found. Transport used a controlled local upstream, not a real paid provider
Main CI is green and Bugbot reports no new issues
TLDR
Problem this solves:
How it solves it:
Intentional product change: new decision routers choose an onboarded decision model instead of entering a provider and raw model name. Legacy router configurations remain supported. Tier assignments start with the existing automatic recommendations and remain editable
User Flow
Before: decision-router setup requires separate provider/model choices and scattered settings
/ui/models-and-endpoints, then Add Auto RouterAfter: the same task starts with the deployment and keeps related settings together
/ui/models-and-endpoints, then Add Auto RouterImplementation
The dropdown intersects available model groups with evaluation mode or existing decision catalog metadata. It saves the deployment alias in
deployment_name. A small classifier adapter calls the existingRouter.adecisionspath, so the selected deployment owns the connection and credentials. Existing key/team dependency checks also apply to this alias. Direct legacy classifier configurations still use their original pathDeployment-backed routers reopen with the same dropdown; ignored legacy provider/model controls are hidden. This fixes the edit regression discovered during independent verification. Access groups only move below the name; their behavior is unchanged. No new endpoints, migrations, routing policies, or provider onboarding changes
Tests
36b18fa2e0passes create/save/invoke, switching between two deployments, legacy connections, prefill/template reset, timeout/invalid-tier fallback, and live member authorization (200/403/400). Transport uses a controlled HTTP upstreamScreenshots / Proof of Fix
Same isolated demo data and controlled upstream on baseline and final source builds
Before (bea0d5c)
/ui/models-and-endpoints, then Add Auto Router and select the decision classifierAfter (d033e6c)
5.04e-07for the controlled 12-token responseCaveats
Severe
deployment_nameconfigurationLow
Type
Pre-Submission checklist